ios/chrome/browser/ui/favicon_view.h - Issue 2361393004: Creates FaviconAttributesProvider.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/favicon_view.h

Issue 2361393004: Creates FaviconAttributesProvider. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_FAVICON_VIEW_H_

	6 #define IOS_CHROME_BROWSER_UI_FAVICON_VIEW_H_

	7

	8 #import <UIKit/UIKit.h>

	9

	10 #import "ios/chrome/browser/favicon/favicon_attributes.h"

	11

	12 @interface FaviconViewNew : UIView

	13

	14 // Default width and height of favicon.

	15 + (CGFloat)defaultSize;
	Jackie Quinn 2016/09/23 23:11:01 Why make this a class method rather than a settabl Why make this a class method rather than a settable property? Or is this even needed? stkhapugin 2016/09/26 15:51:36 You're right, this is useless. Exposing constants Show quoted text On 2016/09/23 23:11:01, Jackie Quinn wrote: > Why make this a class method rather than a settable property? Or is this even > needed? You're right, this is useless. Exposing constants instead.
	16 // Minimum width and height of favicon.

	17 + (CGFloat)minSize;

	18

	19 // Configures this view with given attributes.

	20 - (void)configureWithAttribues:(FaviconAttributes* _Nonnull)attributes;

	21 // Sets monogram font.

	22 - (void)setFont:(UIFont* _Nonnull)font;

	23

	24 @end

	25

	26 #endif // IOS_CHROME_BROWSER_UI_FAVICON_VIEW_H_

OLD	NEW