Throw an ArgumentError if the port is out of range

Throw an ArgumentError if the port is out of range

fixes #27416

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/a76aa4e70c2ec91f5d913951a15f0044d5f252d8

[zra, 2016-09-23 18:02:03]

Description was changed from

==========
Throw an ArgumentError if the port is out of range
==========

to

==========
Throw an ArgumentError if the port is out of range

fixes #27416
==========

[zra, 2016-09-23 18:02:12]

zra@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-09-23 18:05:45]

LGTM with a suggestion

https://codereview.chromium.org/2361373003/diff/1/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/2361373003/diff/1/runtime/bin/socket_patch.da...
runtime/bin/socket_patch.dart:535: if ((port == null) || (port < 0) || (port >
0xffff)) {
this could be factored into:

_throwOnBadPort(port);

[zra, 2016-09-23 18:12:49]

https://codereview.chromium.org/2361373003/diff/1/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/2361373003/diff/1/runtime/bin/socket_patch.da...
runtime/bin/socket_patch.dart:535: if ((port == null) || (port < 0) || (port >
0xffff)) {
On 2016/09/23 18:05:45, Cutch wrote:
> this could be factored into:
> 
> _throwOnBadPort(port);

Done.

[zra, 2016-09-23 18:12:57]

Description was changed from

==========
Throw an ArgumentError if the port is out of range

fixes #27416
==========

to

==========
Throw an ArgumentError if the port is out of range

fixes #27416

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a76aa4e70c2ec91f5d913951a15f0044d5f252d8
==========

[zra, 2016-09-23 18:12:58]

Committed patchset #3 (id:40001) manually as
a76aa4e70c2ec91f5d913951a15f0044d5f252d8 (presubmit successful).