third_party/WebKit/Source/core/layout/LayoutGrid.h - Issue 2361373002: [css-grid] Clearing override sizes before running grid's layout logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 2361373002: [css-grid] Clearing override sizes before running grid's layout logic. (Closed)

Patch Set: Getting back the initial approach, adding some constraints to avoid unneeded relayouts. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutGrid.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h

index b83b4fc3ee18a680b8d1ed31a73e50436f0ff737..1419b25427854f3544fb52a8f8d6af53bdc01f7f 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h

@@ -243,7 +243,7 @@ private:

size_t m_autoRepeatColumns { 0 };

size_t m_autoRepeatRows { 0 };

- bool m_hasAnyOrthogonalChild;

+ Vector<LayoutBox*> m_orthogonalChildren;

std::unique_ptr<OrderedTrackIndexSet> m_autoRepeatEmptyColumns { nullptr };

std::unique_ptr<OrderedTrackIndexSet> m_autoRepeatEmptyRows { nullptr };