Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: ui/display/screen.h

Issue 2361283002: Add GetDisplayWithDisplayId to display::Screen. (Closed)
Patch Set: id Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/display/screen.h
diff --git a/ui/display/screen.h b/ui/display/screen.h
index 79a0035d2565e9aa4b27d5723591ecd4397f403b..76899ac759ab549aa19f3d4733cbcbae49d3fad1 100644
--- a/ui/display/screen.h
+++ b/ui/display/screen.h
@@ -55,6 +55,12 @@ class DISPLAY_EXPORT Screen {
// Returns the list of displays that are currently available.
virtual std::vector<display::Display> GetAllDisplays() const = 0;
+ // Returns true if the display with |display_id| is found and returns that
sky 2016/10/06 15:20:03 Is there a reason this can't be made a helper func
riajiang 2016/10/06 18:26:31 We were thinking to change some subclasses of disp
sky 2016/10/06 21:28:34 That seems orthogonal. You could change subclasses
+ // display in |display|. Otherwise returns false and |display| remains
+ // untouched.
+ virtual bool GetDisplayWithDisplayId(int64_t display_id,
+ display::Display* display) const = 0;
+
// Returns the display nearest the specified window.
// If the window is NULL or the window is not rooted to a display this will
// return the primary display.

Powered by Google App Engine
This is Rietveld 408576698