cc: Use medium filter quality for downscales.

cc: Use medium filter quality for downscales.

This patch makes us use a medium filter quality if one of the dimensions
of an image is being downscaled. There are a couple of things to watch
out for:

1. This may cause worse quality on some images
2. This may regress memory, since mips are larger cache objects than
   specific smallest size.

R=chrishtr@chromium.org, enne@chromium.org
BUG=649046
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/7a49649a96774df16e8f1401137e557e6877a4a1
Cr-Commit-Position: refs/heads/master@{#421375}

[vmpstr, 2016-09-22 21:26:25]

Description was changed from

==========
cc: Use medium filter quality for downscales.

This patch makes us use a medium filter quality if one of the dimensions
of an image is being downscaled. There are a couple of things to watch
out for:

1. This may cause worse quality on some images
2. This may regress memory, since mips are larger cache objects than
   specific smallest size.

R=chrishtr@chromium.org, enne@chromium.org
BUG=649046
==========

to

==========
cc: Use medium filter quality for downscales.

This patch makes us use a medium filter quality if one of the dimensions
of an image is being downscaled. There are a couple of things to watch
out for:

1. This may cause worse quality on some images
2. This may regress memory, since mips are larger cache objects than
   specific smallest size.

R=chrishtr@chromium.org, enne@chromium.org
BUG=649046
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[vmpstr, 2016-09-22 21:27:10]

Description was changed from

==========
cc: Use medium filter quality for downscales.

This patch makes us use a medium filter quality if one of the dimensions
of an image is being downscaled. There are a couple of things to watch
out for:

1. This may cause worse quality on some images
2. This may regress memory, since mips are larger cache objects than
   specific smallest size.

R=chrishtr@chromium.org, enne@chromium.org
BUG=649046
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Use medium filter quality for downscales.

This patch makes us use a medium filter quality if one of the dimensions
of an image is being downscaled. There are a couple of things to watch
out for:

1. This may cause worse quality on some images
2. This may regress memory, since mips are larger cache objects than
   specific smallest size.

R=chrishtr@chromium.org, enne@chromium.org
BUG=649046
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[vmpstr, 2016-09-22 21:27:54]

Please take a look.

[chrishtr, 2016-09-22 21:30:27]

https://codereview.chromium.org/2361243002/diff/1/cc/tiles/software_image_dec...
File cc/tiles/software_image_decode_controller.cc (right):

https://codereview.chromium.org/2361243002/diff/1/cc/tiles/software_image_dec...
cc/tiles/software_image_decode_controller.cc:837: ImageDecodeControllerKey
ImageDecodeControllerKey::FromDrawImage(
unittest this method

[ericrk, 2016-09-22 21:32:26]

ericrk@chromium.org changed reviewers:
+ ericrk@chromium.org

[ericrk, 2016-09-22 21:32:27]

lgtm

makes sense to me given the context in the bug (that Skia is already doing
this)...

[vmpstr, 2016-09-22 21:38:41]

PTAL

https://codereview.chromium.org/2361243002/diff/1/cc/tiles/software_image_dec...
File cc/tiles/software_image_decode_controller.cc (right):

https://codereview.chromium.org/2361243002/diff/1/cc/tiles/software_image_dec...
cc/tiles/software_image_decode_controller.cc:837: ImageDecodeControllerKey
ImageDecodeControllerKey::FromDrawImage(
On 2016/09/22 21:30:27, chrishtr wrote:
> unittest this method

Good idea. Done.

[chrishtr, 2016-09-22 21:40:00]

lgtm

[vmpstr, 2016-09-22 22:19:12]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2016-09-22 22:19:13]

The patchset sent to the CQ was uploaded after l-g-t-m from ericrk@chromium.org
Link to the patchset: https://codereview.chromium.org/2361243002/#ps20001
(title: "mediumq: unittests")

[commit-bot: I haz the power, 2016-09-22 22:19:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 23:41:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:41:02]

Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)

[vmpstr, 2016-09-22 23:49:23]

On 2016/09/22 23:41:02, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)

As expected, a bunch of layout tests failed.
https://storage.googleapis.com/chromium-layout-test-archives/linux_precise_bl...

Please take a look to see if you think it's still acceptable. I think some
pictures actually look sharper and better

[chrishtr, 2016-09-23 00:05:36]

They look ok to me (didn't look at every single one). Here is one improvement:

https://storage.googleapis.com/chromium-layout-test-archives/linux_precise_bl...

[f(malita), 2016-09-23 20:54:59]

fmalita@chromium.org changed reviewers:
+ fmalita@chromium.org

[f(malita), 2016-09-23 20:55:00]

lgtm

[vmpstr, 2016-09-27 21:20:18]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2016-09-27 21:20:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, ericrk@chromium.org, fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/2361243002/#ps120001
(title: "update")

[commit-bot: I haz the power, 2016-09-27 21:20:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 21:23:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 21:23:54]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vmpstr, 2016-09-27 21:45:38]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2016-09-27 21:45:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, fmalita@chromium.org, ericrk@chromium.org
Link to the patchset: https://codereview.chromium.org/2361243002/#ps140001
(title: "update")

[commit-bot: I haz the power, 2016-09-27 21:46:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 23:04:14]

Description was changed from

==========
cc: Use medium filter quality for downscales.

This patch makes us use a medium filter quality if one of the dimensions
of an image is being downscaled. There are a couple of things to watch
out for:

1. This may cause worse quality on some images
2. This may regress memory, since mips are larger cache objects than
   specific smallest size.

R=chrishtr@chromium.org, enne@chromium.org
BUG=649046
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Use medium filter quality for downscales.

This patch makes us use a medium filter quality if one of the dimensions
of an image is being downscaled. There are a couple of things to watch
out for:

1. This may cause worse quality on some images
2. This may regress memory, since mips are larger cache objects than
   specific smallest size.

R=chrishtr@chromium.org, enne@chromium.org
BUG=649046
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-27 23:04:15]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-09-27 23:05:37]

Description was changed from

==========
cc: Use medium filter quality for downscales.

This patch makes us use a medium filter quality if one of the dimensions
of an image is being downscaled. There are a couple of things to watch
out for:

1. This may cause worse quality on some images
2. This may regress memory, since mips are larger cache objects than
   specific smallest size.

R=chrishtr@chromium.org, enne@chromium.org
BUG=649046
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Use medium filter quality for downscales.

This patch makes us use a medium filter quality if one of the dimensions
of an image is being downscaled. There are a couple of things to watch
out for:

1. This may cause worse quality on some images
2. This may regress memory, since mips are larger cache objects than
   specific smallest size.

R=chrishtr@chromium.org, enne@chromium.org
BUG=649046
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/7a49649a96774df16e8f1401137e557e6877a4a1
Cr-Commit-Position: refs/heads/master@{#421375}
==========

[commit-bot: I haz the power, 2016-09-27 23:05:38]

Patchset 8 (id:??) landed as
https://crrev.com/7a49649a96774df16e8f1401137e557e6877a4a1
Cr-Commit-Position: refs/heads/master@{#421375}