Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 236123007: Use ScriptPromiseResolverWithContext. (Closed)

Created:
6 years, 8 months ago by yhirano
Modified:
6 years, 8 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use ScriptPromiseResolverWithContext. Use ScriptPromiseResolverWithContext instead of a pair of ScriptPromiseResolver and NewScriptState. This CL doen't change the behavior in many cases: The only exception is when the resolution / rejection happens on the suspended or stopped ExecutionContext. In such a case, ScriptPromiseResolver suspends or stops resolution or rejection. R=ksakamoto@chromium.org BUG=352552 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -18 lines) Patch
M Source/core/css/FontFace.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/core/css/FontFaceSet.cpp View 7 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yhirano
6 years, 8 months ago (2014-04-14 03:10:37 UTC) #1
Kunihiko Sakamoto
lgtm
6 years, 8 months ago (2014-04-14 03:55:32 UTC) #2
yhirano
+haraken for OWNER review
6 years, 8 months ago (2014-04-14 04:23:03 UTC) #3
haraken
LGTM. Thanks for doing this. I'd be happy if you could replace all hand-written PromiseResolver ...
6 years, 8 months ago (2014-04-14 04:24:41 UTC) #4
yhirano
On 2014/04/14 04:24:41, haraken wrote: > LGTM. Thanks for doing this. I'd be happy if ...
6 years, 8 months ago (2014-04-14 04:34:08 UTC) #5
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 8 months ago (2014-04-14 04:34:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/236123007/1
6 years, 8 months ago (2014-04-14 04:34:23 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 05:04:06 UTC) #8
Message was sent while issue was closed.
Change committed as 171418

Powered by Google App Engine
This is Rietveld 408576698