Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Unified Diff: ui/login/account_picker/user_pod_row.js

Issue 2361193002: Fix clicks on Public Session login page after OOBE (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/login/account_picker/user_pod_row.js
diff --git a/ui/login/account_picker/user_pod_row.js b/ui/login/account_picker/user_pod_row.js
index a65254b35c75fd0c87805324cd953cb9bc53a187..c768f23b65b8f463062696aa727eca776b3228ae 100644
--- a/ui/login/account_picker/user_pod_row.js
+++ b/ui/login/account_picker/user_pod_row.js
@@ -771,7 +771,8 @@ cr.define('login', function() {
this.userClickAuthAllowed_ = false;
// Lazy load the assets needed for the polymer submit button.
- if (cr.isChromeOS && !cr.ui.login.ResourceLoader.alreadyLoadedAssets(
+ if (cr.isChromeOS && this.submitButton &&
+ !cr.ui.login.ResourceLoader.alreadyLoadedAssets(
Greg Levin 2016/09/22 20:31:39 I assume this condition makes sense, and that this
jdufault 2016/09/22 20:52:20 Discussed a bit offline. We should probably just a
'custom-elements-user-pod')) {
cr.ui.login.ResourceLoader.registerAssets({
id: 'custom-elements-user-pod',
@@ -895,7 +896,8 @@ cr.define('login', function() {
* @type {!HTMLInputElement}
*/
get submitButton() {
- return this.querySelector('.submit-button');
+ return this.user_.publicAccount ? null :
+ this.querySelector('.submit-button');
Greg Levin 2016/09/22 20:31:39 Public Session pods don't have Submit buttons. Is
},
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698