Fix clicks on Public Session login page after OOBE

ui/login/account_picker/user_pod_row.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview User pod row implementation.
  */
 
 cr.define('login', function() {
   /**
@@ skipping 753 matching lines @@
       this.imageElement.addEventListener('load',
           this.parentNode.handlePodImageLoad.bind(this.parentNode, this));
 
       var initialAuthType = this.user.initialAuthType ||
           AUTH_TYPE.OFFLINE_PASSWORD;
       this.setAuthType(initialAuthType, null);
 
       this.userClickAuthAllowed_ = false;
 
       // Lazy load the assets needed for the polymer submit button.
-      if (cr.isChromeOS && !cr.ui.login.ResourceLoader.alreadyLoadedAssets(
+      var isLockScreen = (Oobe.getInstance().displayType == DISPLAY_TYPE.LOCK);
+      if (cr.isChromeOS && isLockScreen &&
+          !cr.ui.login.ResourceLoader.alreadyLoadedAssets(

[Greg Levin, 2016/09/23 16:12:40]

As per offline discussion, switched this to only activating on Lock screen.

               'custom-elements-user-pod')) {
         cr.ui.login.ResourceLoader.registerAssets({
             id: 'custom-elements-user-pod',
             html: [{ url: 'custom_elements_user_pod.html' }]
          });
         cr.ui.login.ResourceLoader.loadAssetsOnIdle('custom-elements-user-pod');
       }
     },
 
     /**
@@ skipping 103 matching lines @@
      */
     get passwordElement() {
       return this.querySelector('.password');
     },
 
     /**
      * Gets submit button.
      * @type {!HTMLInputElement}
      */
     get submitButton() {
-      return this.querySelector('.submit-button');
+      return this.user_.publicAccount ? null :
+                                        this.querySelector('.submit-button');

[Greg Levin, 2016/09/23 16:12:40]

Since I'm not using this in the if-condition above, I'm not sure if this check
is of any value.  It disables a bit of code in a case where it's not apparently
used, but I don't know if it's a net improvement.

[xiyuan, 2016/09/23 16:26:00]

I would vote for revert since it is not needed for this CL.

[Greg Levin, 2016/09/23 18:23:09]

Done.

     },
 
     /**
      * Gets the password label, which is used to show a message where the
      * password field is normally.
      * @type {!HTMLInputElement}
      */
     get passwordLabelElement() {
       return this.querySelector('.password-label');
     },
@@ skipping 2330 matching lines @@
           else
             pod.classList.remove('faded');
           pod.reset(false);
         }
       }
 
       // Clear any error messages for previous pod.
       if (!this.isFocused(podToFocus))
         Oobe.clearErrors();
 
-      var hadFocus = !!this.focusedPod_;

[Greg Levin, 2016/09/23 16:12:40]

This variable doesn't appear to be used anywhere.

[xiyuan, 2016/09/23 16:26:01]

Let's remove it then.

[Greg Levin, 2016/09/23 18:23:09]

Done.

       this.focusedPod_ = podToFocus;
       if (podToFocus) {
         // Only show the keyboard if it is fully loaded.
         if (podToFocus.isPinReady())
           podToFocus.setPinVisibility(true);
         podToFocus.classList.remove('faded');
         podToFocus.classList.add('focused');
         if (!podToFocus.multiProfilesPolicyApplied) {
           podToFocus.classList.toggle('signing-in', false);
           if (!opt_skipInputFocus)
@@ skipping 390 matching lines @@
        if (pod && pod.multiProfilesPolicyApplied) {
          pod.userTypeBubbleElement.classList.remove('bubble-shown');
        }
      }
   };
 
   return {
     PodRow: PodRow
   };
 });