Move classses VideoCaptureDeviceClient and VideoCaptureBufferPool to media/capture/video

Move classses VideoCaptureDeviceClient and VideoCaptureBufferPool to media/capture/video

This is a pure refactoring. No new functionality.

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL1.6.3.

* Moved classses VideoCaptureDeviceClient and VideoCaptureBufferPoolImpl plus corresponding
  interfaces from content/browser/renderer_host/media to media/capture/video.
* Break strong dependency of VideoCaptureBufferPoolImpl on content::VideoCaptureBufferTrackerFactory
  by introducing an interface (media::VideoCaptureBufferTrackerFactory).
* Renamed class content::VideoCaptureBufferTrackerFactory to content::RendererHostVideoCaptureBufferTrackerFactory
  and make it an implementation of the newly created interface media::VideoCaptureBufferTrackerFactory
* Move DEPS entry for third_pary/libyuv from content/browser/renderer_host to media/capture/video.
  This dependency is used in class VideoCaptureDeviceClient

BUG=584797
TEST=content_unittest, capture_unittest, video_capture_unittest

[1] https://docs.google.com/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit#heading=h.wql1o34yg0bx

Committed: https://crrev.com/162e19a88fa579c8a770e72801e2c79897a10308
Cr-Commit-Position: refs/heads/master@{#421536}

[chfremer, 2016-09-22 19:01:34]

Description was changed from

==========
Apply patch DeviceClientMove

BUG=
==========

to

==========
Move classses VideoCaptureDeviceClient and VideoCaptureBufferPool to
media/capture/video

This is a pure refactoring. No new functionality.

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1]
CL1.6.3.

* Moved classses VideoCaptureDeviceClient and VideoCaptureBufferPoolImpl plus
corresponding 
  interfaces from content/browser/renderer_host/media to media/capture/video.
* Break strong dependency of VideoCaptureBufferPoolImpl on
content::VideoCaptureBufferTrackerFactory 
  by introducing an interface (media::VideoCaptureBufferTrackerFactory).
* Renamed class content::VideoCaptureBufferTrackerFactory to
content::RendererHostVideoCaptureBufferTrackerFactory
  and make it an implementation of the newly created interface
media::VideoCaptureBufferTrackerFactory
* Move DEPS entry for third_pary/libyuv from content/browser/renderer_host to
media/capture/video. 
  This dependency is used in class VideoCaptureDeviceClient

BUG=584797
TEST=content_unittest, capture_unittest, video_capture_unittest

[1]
https://docs.google.com/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijv...
==========

[chfremer, 2016-09-22 19:01:59]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-09-22 21:41:55]

mcasas@chromium.org changed reviewers:
+ mcasas@chromium.org

[mcasas, 2016-09-22 21:41:59]

Feel free to remove these comments when uploading the definitive patch for
review.

https://codereview.chromium.org/2361173002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc
(right):

https://codereview.chromium.org/2361173002/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc:9: //
this test must lives here and not in media/capture/video.
s/lives/live/

File-class comments are rare in Chromium, I'd say
peg it to the VideoCaptureBufferPoolTest class.

https://codereview.chromium.org/2361173002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_device_client_unittest.cc
(right):

https://codereview.chromium.org/2361173002/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_device_client_unittest.cc:8:
// renderer_host/media, and therefore this test must lives here and not in
s/lives/live/ and the same comment as before.

https://codereview.chromium.org/2361173002/diff/20001/media/capture/BUILD.gn
File media/capture/BUILD.gn (right):

https://codereview.chromium.org/2361173002/diff/20001/media/capture/BUILD.gn#...
media/capture/BUILD.gn:152: deps += [ "//third_party/libyuv" ]
Bc of l.92 you can remove this now.

https://codereview.chromium.org/2361173002/diff/20001/media/capture/video/vid...
File media/capture/video/video_capture_buffer_pool_impl.h (right):

https://codereview.chromium.org/2361173002/diff/20001/media/capture/video/vid...
media/capture/video/video_capture_buffer_pool_impl.h:49: // circulate.
I think these class-comments should go in 
VideoCaptureBufferPool, not in the Impl, wdyt?

https://codereview.chromium.org/2361173002/diff/20001/media/capture/video/vid...
media/capture/video/video_capture_buffer_pool_impl.h:107:
std::unique_ptr<VideoCaptureBufferTrackerFactory> buffer_tracker_factory_;
nit: Probably can be made const.

https://codereview.chromium.org/2361173002/diff/20001/media/capture/video/vid...
File media/capture/video/video_frame_receiver.h (right):

https://codereview.chromium.org/2361173002/diff/20001/media/capture/video/vid...
media/capture/video/video_frame_receiver.h:10: class CAPTURE_EXPORT
VideoFrameReceiver {
nit: now that this class gets a file on its own, it
needs some kind of class documentation.

[chfremer, 2016-09-22 23:24:57]

chfremer@chromium.org changed reviewers:
+ emircan@chromium.org, miu@chromium.org

[chfremer, 2016-09-22 23:24:58]

Adding Reviewers
miu@: Optional Review
emircan@: FYI

[chfremer, 2016-09-22 23:41:52]

mcasas@: PTAL

https://codereview.chromium.org/2361173002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc
(right):

https://codereview.chromium.org/2361173002/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc:9: //
this test must lives here and not in media/capture/video.
On 2016/09/22 21:41:56, mcasas wrote:
> s/lives/live/
> 
> File-class comments are rare in Chromium, I'd say
> peg it to the VideoCaptureBufferPoolTest class.

Done.

https://codereview.chromium.org/2361173002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_device_client_unittest.cc
(right):

https://codereview.chromium.org/2361173002/diff/20001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_device_client_unittest.cc:8:
// renderer_host/media, and therefore this test must lives here and not in
On 2016/09/22 21:41:56, mcasas wrote:
> s/lives/live/ and the same comment as before.

Done.

https://codereview.chromium.org/2361173002/diff/20001/media/capture/BUILD.gn
File media/capture/BUILD.gn (right):

https://codereview.chromium.org/2361173002/diff/20001/media/capture/BUILD.gn#...
media/capture/BUILD.gn:152: deps += [ "//third_party/libyuv" ]
On 2016/09/22 21:41:57, mcasas wrote:
> Bc of l.92 you can remove this now.

Done.

https://codereview.chromium.org/2361173002/diff/20001/media/capture/video/vid...
File media/capture/video/video_capture_buffer_pool_impl.h (right):

https://codereview.chromium.org/2361173002/diff/20001/media/capture/video/vid...
media/capture/video/video_capture_buffer_pool_impl.h:49: // circulate.
On 2016/09/22 21:41:58, mcasas wrote:
> I think these class-comments should go in 
> VideoCaptureBufferPool, not in the Impl, wdyt?

Done.

https://codereview.chromium.org/2361173002/diff/20001/media/capture/video/vid...
media/capture/video/video_capture_buffer_pool_impl.h:107:
std::unique_ptr<VideoCaptureBufferTrackerFactory> buffer_tracker_factory_;
On 2016/09/22 21:41:58, mcasas wrote:
> nit: Probably can be made const.

Done.

https://codereview.chromium.org/2361173002/diff/20001/media/capture/video/vid...
File media/capture/video/video_frame_receiver.h (right):

https://codereview.chromium.org/2361173002/diff/20001/media/capture/video/vid...
media/capture/video/video_frame_receiver.h:10: class CAPTURE_EXPORT
VideoFrameReceiver {
On 2016/09/22 21:41:58, mcasas wrote:
> nit: now that this class gets a file on its own, it
> needs some kind of class documentation.

Done.

[mcasas, 2016-09-27 00:12:57]

lgtm % some small comments.

https://codereview.chromium.org/2361173002/diff/40001/content/browser/rendere...
File
content/browser/renderer_host/media/renderer_host_video_capture_buffer_tracker_factory.h
(right):

https://codereview.chromium.org/2361173002/diff/40001/content/browser/rendere...
content/browser/renderer_host/media/renderer_host_video_capture_buffer_tracker_factory.h:15:
class CONTENT_EXPORT RendererHostVideoCaptureBufferTrackerFactory
since this class is already in 
content/browser/renderer_host, I'd call it
VideoCaptureBufferTrackerFactoryImpl instead.

https://codereview.chromium.org/2361173002/diff/40001/media/capture/video/vid...
File media/capture/video/video_capture_buffer_pool.h (right):

https://codereview.chromium.org/2361173002/diff/40001/media/capture/video/vid...
media/capture/video/video_capture_buffer_pool.h:11: #include
"media/capture/video/video_capture_buffer_handle.h"
Nit: VideoCaptureBufferHandle can be fwd declared?

[chfremer, 2016-09-27 22:32:27]

addressed mcasas@ comments

https://codereview.chromium.org/2361173002/diff/40001/content/browser/rendere...
File
content/browser/renderer_host/media/renderer_host_video_capture_buffer_tracker_factory.h
(right):

https://codereview.chromium.org/2361173002/diff/40001/content/browser/rendere...
content/browser/renderer_host/media/renderer_host_video_capture_buffer_tracker_factory.h:15:
class CONTENT_EXPORT RendererHostVideoCaptureBufferTrackerFactory
On 2016/09/27 00:12:57, mcasas wrote:
> since this class is already in 
> content/browser/renderer_host, I'd call it
> VideoCaptureBufferTrackerFactoryImpl instead.

Done.

https://codereview.chromium.org/2361173002/diff/40001/media/capture/video/vid...
File media/capture/video/video_capture_buffer_pool.h (right):

https://codereview.chromium.org/2361173002/diff/40001/media/capture/video/vid...
media/capture/video/video_capture_buffer_pool.h:11: #include
"media/capture/video/video_capture_buffer_handle.h"
On 2016/09/27 00:12:57, mcasas wrote:
> Nit: VideoCaptureBufferHandle can be fwd declared?

Done.

[chfremer, 2016-09-27 22:35:55]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 22:36:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chfremer, 2016-09-27 22:45:16]

chfremer@chromium.org changed reviewers:
+ avi@chromium.org

[chfremer, 2016-09-27 22:45:17]

avi@chromium.org: PTAL RS for files
* content/browser/BUILD.gn
* content/browser/media/capture/web_contents_video_capture_device_unittest.cc
* content/browser/renderer_host/DEPS

[commit-bot: I haz the power, 2016-09-28 01:18:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 01:18:34]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-09-28 02:18:17]

Those content files stamp lgtm

[chfremer, 2016-09-28 16:27:40]

The CQ bit was checked by chfremer@chromium.org

[chfremer, 2016-09-28 16:27:40]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2361173002/#ps60001
(title: "mcasas@ comments")

[commit-bot: I haz the power, 2016-09-28 16:28:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 16:35:56]

Description was changed from

==========
Move classses VideoCaptureDeviceClient and VideoCaptureBufferPool to
media/capture/video

This is a pure refactoring. No new functionality.

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1]
CL1.6.3.

* Moved classses VideoCaptureDeviceClient and VideoCaptureBufferPoolImpl plus
corresponding 
  interfaces from content/browser/renderer_host/media to media/capture/video.
* Break strong dependency of VideoCaptureBufferPoolImpl on
content::VideoCaptureBufferTrackerFactory 
  by introducing an interface (media::VideoCaptureBufferTrackerFactory).
* Renamed class content::VideoCaptureBufferTrackerFactory to
content::RendererHostVideoCaptureBufferTrackerFactory
  and make it an implementation of the newly created interface
media::VideoCaptureBufferTrackerFactory
* Move DEPS entry for third_pary/libyuv from content/browser/renderer_host to
media/capture/video. 
  This dependency is used in class VideoCaptureDeviceClient

BUG=584797
TEST=content_unittest, capture_unittest, video_capture_unittest

[1]
https://docs.google.com/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijv...
==========

to

==========
Move classses VideoCaptureDeviceClient and VideoCaptureBufferPool to
media/capture/video

This is a pure refactoring. No new functionality.

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1]
CL1.6.3.

* Moved classses VideoCaptureDeviceClient and VideoCaptureBufferPoolImpl plus
corresponding 
  interfaces from content/browser/renderer_host/media to media/capture/video.
* Break strong dependency of VideoCaptureBufferPoolImpl on
content::VideoCaptureBufferTrackerFactory 
  by introducing an interface (media::VideoCaptureBufferTrackerFactory).
* Renamed class content::VideoCaptureBufferTrackerFactory to
content::RendererHostVideoCaptureBufferTrackerFactory
  and make it an implementation of the newly created interface
media::VideoCaptureBufferTrackerFactory
* Move DEPS entry for third_pary/libyuv from content/browser/renderer_host to
media/capture/video. 
  This dependency is used in class VideoCaptureDeviceClient

BUG=584797
TEST=content_unittest, capture_unittest, video_capture_unittest

[1]
https://docs.google.com/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijv...
==========

[commit-bot: I haz the power, 2016-09-28 16:35:57]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-28 16:38:07]

Description was changed from

==========
Move classses VideoCaptureDeviceClient and VideoCaptureBufferPool to
media/capture/video

This is a pure refactoring. No new functionality.

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1]
CL1.6.3.

* Moved classses VideoCaptureDeviceClient and VideoCaptureBufferPoolImpl plus
corresponding 
  interfaces from content/browser/renderer_host/media to media/capture/video.
* Break strong dependency of VideoCaptureBufferPoolImpl on
content::VideoCaptureBufferTrackerFactory 
  by introducing an interface (media::VideoCaptureBufferTrackerFactory).
* Renamed class content::VideoCaptureBufferTrackerFactory to
content::RendererHostVideoCaptureBufferTrackerFactory
  and make it an implementation of the newly created interface
media::VideoCaptureBufferTrackerFactory
* Move DEPS entry for third_pary/libyuv from content/browser/renderer_host to
media/capture/video. 
  This dependency is used in class VideoCaptureDeviceClient

BUG=584797
TEST=content_unittest, capture_unittest, video_capture_unittest

[1]
https://docs.google.com/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijv...
==========

to

==========
Move classses VideoCaptureDeviceClient and VideoCaptureBufferPool to
media/capture/video

This is a pure refactoring. No new functionality.

This CL is part of the Mojo Video Capture work. For the bigger picture, see [1]
CL1.6.3.

* Moved classses VideoCaptureDeviceClient and VideoCaptureBufferPoolImpl plus
corresponding
  interfaces from content/browser/renderer_host/media to media/capture/video.
* Break strong dependency of VideoCaptureBufferPoolImpl on
content::VideoCaptureBufferTrackerFactory
  by introducing an interface (media::VideoCaptureBufferTrackerFactory).
* Renamed class content::VideoCaptureBufferTrackerFactory to
content::RendererHostVideoCaptureBufferTrackerFactory
  and make it an implementation of the newly created interface
media::VideoCaptureBufferTrackerFactory
* Move DEPS entry for third_pary/libyuv from content/browser/renderer_host to
media/capture/video.
  This dependency is used in class VideoCaptureDeviceClient

BUG=584797
TEST=content_unittest, capture_unittest, video_capture_unittest

[1]
https://docs.google.com/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijv...

Committed: https://crrev.com/162e19a88fa579c8a770e72801e2c79897a10308
Cr-Commit-Position: refs/heads/master@{#421536}
==========

[commit-bot: I haz the power, 2016-09-28 16:38:08]

Patchset 3 (id:??) landed as
https://crrev.com/162e19a88fa579c8a770e72801e2c79897a10308
Cr-Commit-Position: refs/heads/master@{#421536}