Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2361163004: [Downloads UI] Fix selection toggle for updated items (Closed)

Created:
4 years, 3 months ago by Theresa
Modified:
4 years, 3 months ago
Reviewers:
Ian Wen
CC:
chromium-reviews, asanka
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads UI] Fix selection toggle for updated items When a download item is updated, its toggle state should carry over from the previous DownloadHistoryItemWrapper. This fixes a bug where a selection remained established if it the Download UI was opened in two windows and a selected item in one window was removed from the other window. Also fixes some variable naming in SelectionDelegate.java BUG=648938 Committed: https://crrev.com/7b9715353ecb38b2a7ab54e1c4f91fd6651bfae0 Cr-Commit-Position: refs/heads/master@{#420788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectionDelegate.java View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Theresa
ptal
4 years, 3 months ago (2016-09-23 20:49:48 UTC) #4
Ian Wen
lgtm
4 years, 3 months ago (2016-09-23 23:32:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361163004/1
4 years, 3 months ago (2016-09-23 23:33:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 23:40:22 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 23:43:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b9715353ecb38b2a7ab54e1c4f91fd6651bfae0
Cr-Commit-Position: refs/heads/master@{#420788}

Powered by Google App Engine
This is Rietveld 408576698