Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2361153002: cocoa browser: remove non-material toolbar support (Closed)

Created:
4 years, 2 months ago by Elly Fong-Jones
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cocoa browser: remove non-material toolbar support This is part 1 of removing non-material top chrome support. BUG=649368 Committed: https://crrev.com/9cceb8fa96365b8f0678384d9385b555f81e1d9b Cr-Commit-Position: refs/heads/master@{#420593}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -282 lines) Patch
M chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm View 2 chunks +7 lines, -50 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm View 6 chunks +3 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 9 chunks +93 lines, -199 lines 3 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.mm View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Elly Fong-Jones
avi: ptal? :)
4 years, 2 months ago (2016-09-22 18:36:36 UTC) #3
Avi (use Gerrit)
stampity stamp lgtm
4 years, 2 months ago (2016-09-22 19:11:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361153002/1
4 years, 2 months ago (2016-09-23 10:49:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-23 11:30:36 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9cceb8fa96365b8f0678384d9385b555f81e1d9b Cr-Commit-Position: refs/heads/master@{#420593}
4 years, 2 months ago (2016-09-23 11:33:19 UTC) #10
Evan Stade
4 years, 2 months ago (2016-09-27 19:34:52 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/2361153002/diff/1/chrome/browser/ui/cocoa/too...
File chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm (right):

https://codereview.chromium.org/2361153002/diff/1/chrome/browser/ui/cocoa/too...
chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:83: const CGFloat
kMaterialDesignLocationBarHeight = 28;
nit: remove references to MD

https://codereview.chromium.org/2361153002/diff/1/chrome/browser/ui/cocoa/too...
chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:335: // Replace the app
button from the nib with an AppToolbarButton instance for
can you remove AppToolbarButtonCell now too?

https://codereview.chromium.org/2361153002/diff/1/chrome/browser/ui/cocoa/too...
chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:336: // Material Design.
nit: remove references to material design (since it's the only design)

Powered by Google App Engine
This is Rietveld 408576698