Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3168)

Unified Diff: chrome/browser/ui/views/collected_cookies_views.cc

Issue 2361123002: CollectedCookiesViews: don't show info for unfocused cookies (Closed)
Patch Set: HasFocus -> IsDrawn Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/collected_cookies_views.cc
diff --git a/chrome/browser/ui/views/collected_cookies_views.cc b/chrome/browser/ui/views/collected_cookies_views.cc
index 1216bd7dfb44cd9795d655e32da907a5d597657e..75f6221204380c2cc0fdc7fbf9263c79b79f8c34 100644
--- a/chrome/browser/ui/views/collected_cookies_views.cc
+++ b/chrome/browser/ui/views/collected_cookies_views.cc
@@ -497,9 +497,12 @@ void CollectedCookiesViews::EnableControls() {
}
void CollectedCookiesViews::ShowCookieInfo() {
- ui::TreeModelNode* node = allowed_cookies_tree_->GetSelectedNode();
- if (!node)
- node = blocked_cookies_tree_->GetSelectedNode();
+ ui::TreeModelNode* node = allowed_cookies_tree_->IsDrawn() ?
+ allowed_cookies_tree_->GetSelectedNode() : nullptr;
+ if (!node) {
+ node = blocked_cookies_tree_->IsDrawn() ?
sky 2016/09/23 17:52:36 Move this into if, e.g. line 502 becomes: if (!nod
Elly Fong-Jones 2016/09/23 18:31:26 Done.
+ blocked_cookies_tree_->GetSelectedNode() : nullptr;
+ }
if (node) {
CookieTreeNode* cookie_node = static_cast<CookieTreeNode*>(node);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698