CollectedCookiesViews: don't show info for unfocused cookies

chrome/browser/ui/views/collected_cookies_views.cc

Index: chrome/browser/ui/views/collected_cookies_views.cc
diff --git a/chrome/browser/ui/views/collected_cookies_views.cc b/chrome/browser/ui/views/collected_cookies_views.cc
index 1216bd7dfb44cd9795d655e32da907a5d597657e..f27f79f4844a68304573b5e7f5f233868604c450 100644
--- a/chrome/browser/ui/views/collected_cookies_views.cc
+++ b/chrome/browser/ui/views/collected_cookies_views.cc
@@ -497,9 +497,12 @@ void CollectedCookiesViews::EnableControls() {
 }
 
 void CollectedCookiesViews::ShowCookieInfo() {
-  ui::TreeModelNode* node = allowed_cookies_tree_->GetSelectedNode();
-  if (!node)
-    node = blocked_cookies_tree_->GetSelectedNode();
+  ui::TreeModelNode* node = allowed_cookies_tree_->HasFocus() ?

[sky, 2016/09/22 19:35:15]

How come you are checking focus and not visibilty? It seems like you should be
showing the cookies for the visible tree which is not necessarily the focused
tree.

[Elly Fong-Jones, 2016/09/23 12:38:08]

Hm. I originally did this because both trees had visible() == true, but I just
found IsDrawn(), which does the right thing, since the trees remain visible but
the TabbedPane container views are set visible/invisible as the active tab
changes. So, I changed this to IsDrawn().

+                            allowed_cookies_tree_->GetSelectedNode() : nullptr;
+  if (!node) {
+    node = blocked_cookies_tree_->HasFocus() ?
+           blocked_cookies_tree_->GetSelectedNode() : nullptr;
+  }
 
   if (node) {
     CookieTreeNode* cookie_node = static_cast<CookieTreeNode*>(node);