CollectedCookiesViews: don't show info for unfocused cookies

CollectedCookiesViews: don't show info for unfocused cookies

When the tab switches between allowed and blocked, cookie info
from the previous tab should no longer be shown.

BUG=649006
Committed: https://crrev.com/c6d0504e2b81609e816ed8f294cb09324efd41be
Cr-Commit-Position: refs/heads/master@{#420693}

[Elly Fong-Jones, 2016-09-22 17:34:14]

Description was changed from

==========
CollectedCookiesViews: don't show info for unfocused cookies

When the tab switches between allowed and blocked, cookie info
from the previous tab should no longer be shown.

BUG=649006
==========

to

==========
CollectedCookiesViews: don't show info for unfocused cookies

When the tab switches between allowed and blocked, cookie info
from the previous tab should no longer be shown.

BUG=649006
==========

[Elly Fong-Jones, 2016-09-22 17:34:14]

ellyjones@chromium.org changed reviewers:
+ sky@chromium.org

[Elly Fong-Jones, 2016-09-22 17:34:20]

sky: ptal? :)

[sky, 2016-09-22 19:35:15]

https://codereview.chromium.org/2361123002/diff/1/chrome/browser/ui/views/col...
File chrome/browser/ui/views/collected_cookies_views.cc (right):

https://codereview.chromium.org/2361123002/diff/1/chrome/browser/ui/views/col...
chrome/browser/ui/views/collected_cookies_views.cc:500: ui::TreeModelNode* node
= allowed_cookies_tree_->HasFocus() ?
How come you are checking focus and not visibilty? It seems like you should be
showing the cookies for the visible tree which is not necessarily the focused
tree.

[Elly Fong-Jones, 2016-09-23 12:38:08]

sky: ptal? :)

https://codereview.chromium.org/2361123002/diff/1/chrome/browser/ui/views/col...
File chrome/browser/ui/views/collected_cookies_views.cc (right):

https://codereview.chromium.org/2361123002/diff/1/chrome/browser/ui/views/col...
chrome/browser/ui/views/collected_cookies_views.cc:500: ui::TreeModelNode* node
= allowed_cookies_tree_->HasFocus() ?
On 2016/09/22 19:35:15, sky wrote:
> How come you are checking focus and not visibilty? It seems like you should be
> showing the cookies for the visible tree which is not necessarily the focused
> tree.

Hm. I originally did this because both trees had visible() == true, but I just
found IsDrawn(), which does the right thing, since the trees remain visible but
the TabbedPane container views are set visible/invisible as the active tab
changes. So, I changed this to IsDrawn().

[sky, 2016-09-23 17:52:36]

Indeed IsDrawn was what I thinking of. Sorry for not being clear. LGTM

https://codereview.chromium.org/2361123002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/collected_cookies_views.cc (right):

https://codereview.chromium.org/2361123002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/collected_cookies_views.cc:503: node =
blocked_cookies_tree_->IsDrawn() ?
Move this into if, e.g. line 502 becomes:
if (!node && blocked_cooked_tree_->IsDrawn()) ...

[Elly Fong-Jones, 2016-09-23 18:31:26]

https://codereview.chromium.org/2361123002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/collected_cookies_views.cc (right):

https://codereview.chromium.org/2361123002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/collected_cookies_views.cc:503: node =
blocked_cookies_tree_->IsDrawn() ?
On 2016/09/23 17:52:36, sky wrote:
> Move this into if, e.g. line 502 becomes:
> if (!node && blocked_cooked_tree_->IsDrawn()) ...

Done.

[Elly Fong-Jones, 2016-09-23 18:31:30]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-09-23 18:31:31]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2361123002/#ps40001
(title: "simplify")

[commit-bot: I haz the power, 2016-09-23 18:32:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 19:27:40]

Description was changed from

==========
CollectedCookiesViews: don't show info for unfocused cookies

When the tab switches between allowed and blocked, cookie info
from the previous tab should no longer be shown.

BUG=649006
==========

to

==========
CollectedCookiesViews: don't show info for unfocused cookies

When the tab switches between allowed and blocked, cookie info
from the previous tab should no longer be shown.

BUG=649006
==========

[commit-bot: I haz the power, 2016-09-23 19:27:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-23 19:29:54]

Description was changed from

==========
CollectedCookiesViews: don't show info for unfocused cookies

When the tab switches between allowed and blocked, cookie info
from the previous tab should no longer be shown.

BUG=649006
==========

to

==========
CollectedCookiesViews: don't show info for unfocused cookies

When the tab switches between allowed and blocked, cookie info
from the previous tab should no longer be shown.

BUG=649006

Committed: https://crrev.com/c6d0504e2b81609e816ed8f294cb09324efd41be
Cr-Commit-Position: refs/heads/master@{#420693}
==========

[commit-bot: I haz the power, 2016-09-23 19:29:55]

Patchset 3 (id:??) landed as
https://crrev.com/c6d0504e2b81609e816ed8f294cb09324efd41be
Cr-Commit-Position: refs/heads/master@{#420693}