Change implementation of flush-count based GrGpuResource purging

Change implementation of flush-count based GrGpuResource purging

Change default to approx 30seconds (given some API usage assumptions)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361093002

Committed: https://skia.googlesource.com/skia/+/e2e87f3484e5524dbfd6c01f402136738d1d434b

[bsalomon, 2016-09-22 16:34:47]

Description was changed from

==========
Change implementation of flush-count based GrGpuResource purging

Change default to approx 30seconds (given some API usage assumptions)
==========

to

==========
Change implementation of flush-count based GrGpuResource purging

Change default to approx 30seconds (given some API usage assumptions)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361093002
==========

[bsalomon, 2016-09-22 16:39:30]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-09-22 16:39:31]

This is a bit simplified by tracking an additional stat per-resource rather than
a ring buffer of flush timestamps. This makes it more practical to bump the
threshold up to larger values.

[robertphillips, 2016-09-22 17:55:56]

lgtm

https://codereview.chromium.org/2361093002/diff/20001/src/gpu/GrResourceCache...
File src/gpu/GrResourceCache.cpp (right):

https://codereview.chromium.org/2361093002/diff/20001/src/gpu/GrResourceCache...
src/gpu/GrResourceCache.cpp:460: while (fPurgeableQueue.count()) {
oldestResourceFlushCnt doesn't seem like the right name here. Maybe
resourceBecamePurgeableAt ?

https://codereview.chromium.org/2361093002/diff/20001/src/gpu/GrResourceCache...
src/gpu/GrResourceCache.cpp:463: if (oldestAllowedFlushCnt <
oldestResourceFlushCnt) {
// comment why this is break and not continue

?

[bsalomon, 2016-09-22 18:09:55]

https://codereview.chromium.org/2361093002/diff/20001/src/gpu/GrResourceCache...
File src/gpu/GrResourceCache.cpp (right):

https://codereview.chromium.org/2361093002/diff/20001/src/gpu/GrResourceCache...
src/gpu/GrResourceCache.cpp:460: while (fPurgeableQueue.count()) {
On 2016/09/22 17:55:56, robertphillips wrote:
> oldestResourceFlushCnt doesn't seem like the right name here. Maybe
> resourceBecamePurgeableAt ?

Done.

https://codereview.chromium.org/2361093002/diff/20001/src/gpu/GrResourceCache...
src/gpu/GrResourceCache.cpp:463: if (oldestAllowedFlushCnt <
oldestResourceFlushCnt) {
On 2016/09/22 17:55:56, robertphillips wrote:
> // comment why this is break and not continue
> 
> ?

Done.

[bsalomon, 2016-09-22 18:11:39]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-09-22 18:11:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2361093002/#ps60001
(title: "fix var spelling")

[commit-bot: I haz the power, 2016-09-22 18:11:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 19:42:12]

Description was changed from

==========
Change implementation of flush-count based GrGpuResource purging

Change default to approx 30seconds (given some API usage assumptions)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361093002
==========

to

==========
Change implementation of flush-count based GrGpuResource purging

Change default to approx 30seconds (given some API usage assumptions)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361093002

Committed:
https://skia.googlesource.com/skia/+/e2e87f3484e5524dbfd6c01f402136738d1d434b
==========

[commit-bot: I haz the power, 2016-09-22 19:42:13]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/e2e87f3484e5524dbfd6c01f402136738d1d434b