Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: src/heap/heap.cc

Issue 2361073002: [heap] Remove --print-cumulative-gc-stat flag. (Closed)
Patch Set: unused variables Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.h ('k') | src/heap/incremental-marking.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index 2472d45b7faf8eced8091f8205348530c80902b7..3e515c643aac98ca0c7961adaf1b042d21822d0a 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -125,12 +125,6 @@ Heap::Heap()
nodes_copied_in_new_space_(0),
nodes_promoted_(0),
maximum_size_scavenges_(0),
- max_gc_pause_(0.0),
- total_gc_time_ms_(0.0),
- max_alive_after_gc_(0),
- min_in_mutator_(kMaxInt),
- marking_time_(0.0),
- sweeping_time_(0.0),
last_idle_notification_time_(0.0),
last_gc_time_(0.0),
scavenge_collector_(nullptr),
@@ -5593,20 +5587,6 @@ void Heap::TearDown() {
UpdateMaximumCommitted();
- if (FLAG_print_cumulative_gc_stat) {
- PrintF("\n");
- PrintF("gc_count=%d ", gc_count_);
- PrintF("mark_sweep_count=%d ", ms_count_);
- PrintF("max_gc_pause=%.1f ", get_max_gc_pause());
- PrintF("total_gc_time=%.1f ", total_gc_time_ms_);
- PrintF("min_in_mutator=%.1f ", get_min_in_mutator());
- PrintF("max_alive_after_gc=%" V8PRIdPTR " ", get_max_alive_after_gc());
- PrintF("total_marking_time=%.1f ", tracer()->cumulative_marking_duration());
- PrintF("total_sweeping_time=%.1f ",
- tracer()->cumulative_sweeping_duration());
- PrintF("\n\n");
- }
-
if (FLAG_print_max_heap_committed) {
PrintF("\n");
PrintF("maximum_committed_by_heap=%" V8PRIdPTR " ",
@@ -6375,20 +6355,10 @@ void Heap::TracePathToGlobal() {
}
#endif
-
-void Heap::UpdateCumulativeGCStatistics(double duration,
- double spent_in_mutator,
- double marking_time) {
- if (FLAG_print_cumulative_gc_stat) {
- total_gc_time_ms_ += duration;
- max_gc_pause_ = Max(max_gc_pause_, duration);
- max_alive_after_gc_ = Max(max_alive_after_gc_, SizeOfObjects());
- min_in_mutator_ = Min(min_in_mutator_, spent_in_mutator);
- } else if (FLAG_trace_gc_verbose) {
+void Heap::UpdateTotalGCTime(double duration) {
+ if (FLAG_trace_gc_verbose) {
total_gc_time_ms_ += duration;
}
-
- marking_time_ += marking_time;
}
void Heap::ExternalStringTable::CleanUp() {
« no previous file with comments | « src/heap/heap.h ('k') | src/heap/incremental-marking.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698