Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2361053004: Revert of [wasm] Master CL for Binary 0xC changes. (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Master CL for Binary 0xC changes. (patchset #26 id:490001 of https://codereview.chromium.org/2345593003/ ) Reason for revert: Main suspect for tsan: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11893 Also changes layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10036 +mips builder: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/4032 Original issue's description: > [wasm] Master CL for Binary 0xC changes. > > [0xC] Convert to stack machine semantics. > [0xC] Use section codes instead of names. > [0xC] Add elements section decoding. > [0xC] Decoding of globals section. > [0xC] Decoding of memory section. > [0xC] Decoding of imports section. > [0xC] Decoding of exports section. > [0xC] Decoding of data section. > [0xC] Remove CallImport bytecode. > [0xC] Function bodies have an implicit block. > [0xC] Remove the bottom label from loops. > [0xC] Add signatures to blocks. > [0xC] Remove arities from branches. > Add tests for init expression decoding. > Rework compilation of import wrappers and how they are patched. > Rework function indices in debugging. > Fix ASM->WASM builder for stack machine. > Reorganize asm.js foreign functions due to import indices change. > > R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org > BUG=chromium:575167 > LOG=Y > > Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 > Cr-Commit-Position: refs/heads/master@{#39678} TBR=ahaas@chromium.org,bradnelson@chromium.org,mtrofin@chromium.org,rossberg@chromium.org,bradnelson@google.com,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167 Committed: https://crrev.com/e1eee748dd04a40aeb25ec311f020d5abe182f22 Cr-Commit-Position: refs/heads/master@{#39685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4664 lines, -5876 lines) Patch
M src/asmjs/asm-js.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/asmjs/asm-typer.h View 3 chunks +1 line, -16 lines 0 comments Download
M src/asmjs/asm-typer.cc View 4 chunks +5 lines, -19 lines 0 comments Download
M src/asmjs/asm-wasm-builder.cc View 44 chunks +181 lines, -268 lines 0 comments Download
M src/compiler/int64-lowering.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/compiler/wasm-compiler.h View 4 chunks +9 lines, -9 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 8 chunks +45 lines, -57 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/wasm/ast-decoder.h View 5 chunks +54 lines, -125 lines 0 comments Download
M src/wasm/ast-decoder.cc View 42 chunks +338 lines, -381 lines 0 comments Download
M src/wasm/decoder.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/wasm/encoder.h View 4 chunks +11 lines, -25 lines 0 comments Download
M src/wasm/encoder.cc View 10 chunks +63 lines, -130 lines 0 comments Download
M src/wasm/module-decoder.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/wasm/module-decoder.cc View 18 chunks +403 lines, -694 lines 0 comments Download
M src/wasm/wasm-debug.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/wasm/wasm-interpreter.h View 3 chunks +13 lines, -4 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 23 chunks +176 lines, -161 lines 0 comments Download
M src/wasm/wasm-js.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/wasm/wasm-js.cc View 6 chunks +18 lines, -28 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 6 chunks +65 lines, -97 lines 0 comments Download
M src/wasm/wasm-module.h View 13 chunks +113 lines, -112 lines 0 comments Download
M src/wasm/wasm-module.cc View 31 chunks +710 lines, -567 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 5 chunks +3 lines, -9 lines 0 comments Download
M src/wasm/wasm-result.h View 1 chunk +13 lines, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 55 chunks +317 lines, -522 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 10 chunks +30 lines, -31 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-interpreter.cc View 7 chunks +25 lines, -33 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-js.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 10 chunks +65 lines, -43 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-relocation.cc View 1 chunk +36 lines, -37 lines 0 comments Download
M test/cctest/wasm/test-wasm-function-name-table.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/wasm/test-wasm-trap-position.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 4 chunks +3 lines, -11 lines 0 comments Download
M test/common/wasm/wasm-module-runner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/fuzzer/wasm-code.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/fuzzer/wasm-data-section.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/fuzzer/wasm-function-sigs-section.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/fuzzer/wasm-globals-section.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/fuzzer/wasm-imports-section.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/fuzzer/wasm-memory-section.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/fuzzer/wasm-names-section.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/fuzzer/wasm-section-fuzzers.h View 1 chunk +1 line, -1 line 0 comments Download
M test/fuzzer/wasm-section-fuzzers.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M test/fuzzer/wasm-types-section.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 2 chunks +0 lines, -2 lines 0 comments Download
D test/mjsunit/wasm/asm-wasm-expr.js View 1 chunk +0 lines, -151 lines 0 comments Download
M test/mjsunit/wasm/calls.js View 1 chunk +4 lines, -7 lines 0 comments Download
M test/mjsunit/wasm/compiled-module-management.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/compiled-module-serialization.js View 2 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/wasm/debug-disassembly.js View 3 chunks +6 lines, -6 lines 0 comments Download
M test/mjsunit/wasm/ensure-wasm-binaries-up-to-date.js View 1 chunk +0 lines, -21 lines 0 comments Download
M test/mjsunit/wasm/exceptions.js View 3 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/export-table.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/ffi.js View 5 chunks +9 lines, -9 lines 0 comments Download
M test/mjsunit/wasm/ffi-error.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/frame-inspection.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/function-names.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/gc-frame.js View 2 chunks +2 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/grow-memory.js View 2 chunks +5 lines, -8 lines 0 comments Download
M test/mjsunit/wasm/import-table.js View 4 chunks +6 lines, -6 lines 0 comments Download
M test/mjsunit/wasm/incrementer.wasm View Binary file 0 comments Download
M test/mjsunit/wasm/indirect-calls.js View 3 chunks +4 lines, -41 lines 0 comments Download
D test/mjsunit/wasm/instance-gc.js View 1 chunk +0 lines, -122 lines 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 10 chunks +10 lines, -20 lines 0 comments Download
M test/mjsunit/wasm/module-memory.js View 4 chunks +26 lines, -35 lines 0 comments Download
M test/mjsunit/wasm/parallel_compilation.js View 2 chunks +5 lines, -8 lines 0 comments Download
M test/mjsunit/wasm/receiver.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/stack.js View 7 chunks +10 lines, -10 lines 0 comments Download
M test/mjsunit/wasm/stackwalk.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/start-function.js View 3 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/test-import-export-wrapper.js View 12 chunks +24 lines, -24 lines 0 comments Download
M test/mjsunit/wasm/test-wasm-module-builder.js View 7 chunks +7 lines, -7 lines 0 comments Download
M test/mjsunit/wasm/trap-location.js View 2 chunks +14 lines, -14 lines 0 comments Download
M test/mjsunit/wasm/unicode-validation.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/verify-function-simple.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 6 chunks +27 lines, -27 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 10 chunks +40 lines, -85 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 48 chunks +1012 lines, -1014 lines 0 comments Download
M test/unittests/wasm/control-transfer-unittest.cc View 4 chunks +217 lines, -281 lines 0 comments Download
M test/unittests/wasm/loop-assignment-analysis-unittest.cc View 5 chunks +20 lines, -17 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 49 chunks +401 lines, -431 lines 0 comments Download
M test/unittests/wasm/wasm-macro-gen-unittest.cc View 2 chunks +50 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [wasm] Master CL for Binary 0xC changes.
4 years, 3 months ago (2016-09-23 17:57:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361053004/1
4 years, 3 months ago (2016-09-23 17:57:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 17:58:18 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 17:58:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1eee748dd04a40aeb25ec311f020d5abe182f22
Cr-Commit-Position: refs/heads/master@{#39685}

Powered by Google App Engine
This is Rietveld 408576698