Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2361023003: Revert of Add ClientNativePixmap multi-planar support. (Closed)

Created:
4 years, 2 months ago by Daniele Castagna
Modified:
4 years, 2 months ago
CC:
chromium-reviews, gurchetansingh, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, wuchengli
Base URL:
https://chromium.googlesource.com/chromium/src.git@client-native-pixmap-dmabug-multiple-planes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add ClientNativePixmap multi-planar support. (patchset #8 id:160001 of https://codereview.chromium.org/2272153002/ ) Reason for revert: This makes samus stuck at the Chrome logo. Original issue's description: > Add ClientNativePixmap multi-planar support. > > ClientNativePixmap, that lets clients map pixmaps in user space, > always assumed a pixmap contained only one plane. > > This CL adds support for multiple-planes. > > BUG=618516 > TBR=posciak > TEST=gl_unittests on samus. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/cdb357b81306f5e8170027d13d931b8e26140405 > Cr-Commit-Position: refs/heads/master@{#420251} TBR=ccameron@chromium.org,dnicoara@chromium.org,posciak@chromium.org,reveman@chromium.org,spang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618516 Committed: https://crrev.com/f6d9dbe12ab44cd7c99e07e57ba97aa7c0ba29f6 Cr-Commit-Position: refs/heads/master@{#420501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -137 lines) Patch
M chrome/gpu/arc_gpu_video_decode_accelerator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/exo/wayland/server.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/ipc/client/gpu_memory_buffer_impl_ozone_native_pixmap.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/client/gpu_memory_buffer_impl_ozone_native_pixmap.cc View 2 chunks +14 lines, -4 lines 0 comments Download
M media/gpu/video_decode_accelerator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/native_pixmap_handle.h View 3 chunks +2 lines, -5 lines 0 comments Download
M ui/gfx/native_pixmap_handle.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M ui/ozone/gl/gl_image_ozone_native_pixmap_drm_unittest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M ui/ozone/gl/gl_image_ozone_native_pixmap_unittest.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M ui/ozone/platform/cast/client_native_pixmap_factory_cast.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc View 2 chunks +8 lines, -14 lines 0 comments Download
M ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.h View 1 chunk +11 lines, -12 lines 0 comments Download
M ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc View 2 chunks +24 lines, -35 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.cc View 3 chunks +9 lines, -19 lines 0 comments Download
M ui/ozone/public/client_native_pixmap.h View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Daniele Castagna
Created Revert of Add ClientNativePixmap multi-planar support.
4 years, 2 months ago (2016-09-22 23:35:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361023003/1
4 years, 2 months ago (2016-09-22 23:35:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-22 23:37:17 UTC) #4
hshi1
lgtm
4 years, 2 months ago (2016-09-22 23:37:24 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 23:40:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6d9dbe12ab44cd7c99e07e57ba97aa7c0ba29f6
Cr-Commit-Position: refs/heads/master@{#420501}

Powered by Google App Engine
This is Rietveld 408576698