Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2361013003: Revert of Fix bitfield enums to not trigger upcoming Clang warning (Closed)

Created:
4 years, 3 months ago by sashab
Modified:
4 years, 3 months ago
CC:
Reid Kleckner, Nico, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Fix bitfield enums to not trigger upcoming Clang warning (patchset #3 id:40001 of https://codereview.chromium.org/2349153002/ ) Reason for revert: Causes warning in GCC. Original issue's description: > Fix bitfield enums to not trigger upcoming Clang warning > > Fix bitfield enums to not trigger upcoming Clang warning regarding > non-unsigned enum bitfields producing non-portable code. > > For more details, see the patch here: https://reviews.llvm.org/D24289 > > BUG=648462 > > Committed: https://crrev.com/a81e00d533454a7179f8f954505a8f033e941a8a > Cr-Commit-Position: refs/heads/master@{#39649} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=648462 Committed: https://crrev.com/e6c1081fe605d73c8e7b52c68bcf3bdc2a4c6b58 Cr-Commit-Position: refs/heads/master@{#39663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/base/safe_conversions_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/globals.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/messages.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
sashab
Created Revert of Fix bitfield enums to not trigger upcoming Clang warning
4 years, 3 months ago (2016-09-23 02:26:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361013003/1
4 years, 3 months ago (2016-09-23 02:26:25 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-23 02:26:27 UTC) #5
vogelheim
lgtm
4 years, 3 months ago (2016-09-23 13:21:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361013003/1
4 years, 3 months ago (2016-09-23 13:22:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 13:22:32 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 13:22:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6c1081fe605d73c8e7b52c68bcf3bdc2a4c6b58
Cr-Commit-Position: refs/heads/master@{#39663}

Powered by Google App Engine
This is Rietveld 408576698