Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2360993002: [builtins] Fix Generate_AtomicsStore. (Closed)

Created:
4 years, 3 months ago by epertoso
Modified:
4 years, 3 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Fix Generate_AtomicsStore. An AtomicStore was used as an input to SmiTag. R=jgruber@chromium.org BUG= Committed: https://crrev.com/7c498d979af1d1ff380d923c670683e402d9f38c Cr-Commit-Position: refs/heads/master@{#39618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/builtins/builtins-sharedarraybuffer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
epertoso
4 years, 3 months ago (2016-09-22 08:22:33 UTC) #3
jgruber
lgtm
4 years, 3 months ago (2016-09-22 08:25:39 UTC) #4
epertoso
4 years, 3 months ago (2016-09-22 08:51:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360993002/1
4 years, 3 months ago (2016-09-22 08:52:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 08:55:12 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 08:55:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c498d979af1d1ff380d923c670683e402d9f38c
Cr-Commit-Position: refs/heads/master@{#39618}

Powered by Google App Engine
This is Rietveld 408576698