Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Issue 2360973004: fix #27408, reverts "ignore dynamic in inference" (Closed)

Created:
4 years, 3 months ago by Jennifer Messerly
Modified:
4 years, 3 months ago
Reviewers:
vsm, Leaf
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : run ddc presumbit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -79 lines) Patch
M CHANGELOG.md View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 2 chunks +6 lines, -10 lines 0 comments Download
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 8 chunks +9 lines, -11 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 8 chunks +9 lines, -11 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 8 chunks +9 lines, -11 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 8 chunks +9 lines, -11 lines 0 comments Download
M pkg/dev_compiler/test/codegen/language/regress_21998_3_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen/language/regress_21998_4_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen/language/regress_21998_lib2.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen/language/regress_21998_lib3.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen_expected/varargs.js View 1 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jennifer Messerly
4 years, 3 months ago (2016-09-23 23:16:18 UTC) #2
Jennifer Messerly
4 years, 3 months ago (2016-09-23 23:16:26 UTC) #4
vsm
lgtm
4 years, 3 months ago (2016-09-23 23:17:20 UTC) #5
vsm
On 2016/09/23 23:17:20, vsm wrote: > lgtm Can you rerun presubmit for DDC? Might change ...
4 years, 3 months ago (2016-09-23 23:17:51 UTC) #6
Jennifer Messerly
good catch, I did need to rerun DDC presubmit. Got my branches crossed.
4 years, 3 months ago (2016-09-23 23:59:03 UTC) #7
Jennifer Messerly
4 years, 3 months ago (2016-09-24 00:01:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
361cd4c61cb9de4a71ebe9a3edf350f5f116971a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698