Add some more TODOs for places to instrument certificate errors.

net/cert/internal/signature_algorithm_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/internal/signature_algorithm.h"
 
 #include <memory>
 
 #include "base/files/file_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "net/cert/internal/cert_errors.h"
 #include "net/cert/pem_tokenizer.h"
 #include "net/der/input.h"
 #include "net/der/parser.h"
 #include "net/test/test_data_directory.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 namespace {
 
 // Creates a SignatureAlgorithm given the DER as a byte array. Returns true on
 // success and fills |*out| with a non-null pointer.
 template <size_t N>
 bool ParseDer(const uint8_t (&data)[N],
               std::unique_ptr<SignatureAlgorithm>* out) {
-  // TODO(crbug.com/634443): Test the errors.
   CertErrors errors;
   *out = SignatureAlgorithm::Create(der::Input(data, N), &errors);
-  return !!*out;
+  bool success = !!*out;
+
+  // TODO(crbug.com/634443): Test the errors.
+  // if (!success)
+  //   EXPECT_FALSE(errors.empty());
+
+  return success;
 }
 
 // Parses a SignatureAlgorithm given an empty DER input.
 TEST(SignatureAlgorithmTest, ParseDerEmpty) {
-  // TODO(crbug.com/634443): Test the errors.
   CertErrors errors;
   std::unique_ptr<SignatureAlgorithm> algorithm =
       SignatureAlgorithm::Create(der::Input(), &errors);
   ASSERT_FALSE(algorithm);
+  // TODO(crbug.com/634443): Test the errors.
+  // EXPECT_FALSE(errors.empty());
 }
 
 // Parses a SignatureAlgorithm given invalid DER input.
 TEST(SignatureAlgorithmTest, ParseDerBogus) {
   const uint8_t kData[] = {0x00};
   std::unique_ptr<SignatureAlgorithm> algorithm;
   ASSERT_FALSE(ParseDer(kData, &algorithm));
 }
 
 // Parses a sha1WithRSAEncryption which contains a NULL parameters field.
@@ skipping 1004 matching lines @@
   const RsaPssParameters* params = algorithm->ParamsForRsaPss();
 
   ASSERT_TRUE(params);
   EXPECT_EQ(DigestAlgorithm::Sha256, params->mgf1_hash());
   EXPECT_EQ(10u, params->salt_length());
 }
 
 }  // namespace
 
 }  // namespace net