[Chrome OS MD] Update the color of update button and improve its appearance

Update the color of update button and improve its appearance

Update the vector icon for tray update button, so it looks more
clear on screen. This cl also updates the color of low severity
tray update button from green to white.

BUG=643401, 646570
Committed: https://crrev.com/d426dc23088e12be0a3b5a12fc388e5eaa4209d2
Cr-Commit-Position: refs/heads/master@{#420448}

[yiyix, 2016-09-22 03:41:00]

Description was changed from

==========
initial fix for update icon

BUG=
==========

to

==========
Update the color of update button and improve its appearance

Update the vector icon for tray update button, so it looks more 
clear on screen. This cl also updates the color of low severity 
tray update button from green to white. 

BUG=643401, 646570
==========

[yiyix, 2016-09-22 03:41:00]

yiyix@chromium.org changed reviewers:
+ tdanderson@chromium.org

[yiyix, 2016-09-22 03:41:29]

On 2016/09/22 03:41:00, yiyix wrote:
> mailto:yiyix@chromium.org changed reviewers:
> + mailto:tdanderson@chromium.org

@tdanderson, could you please take a look at this change? it is short. Thanks.

[tdanderson, 2016-09-22 14:38:21]

lgtm with two comments addressed

https://chromiumcodereview.appspot.com/2360933002/diff/1/ash/common/system/up...
File ash/common/system/update/tray_update.cc (right):

https://chromiumcodereview.appspot.com/2360933002/diff/1/ash/common/system/up...
ash/common/system/update/tray_update.cc:18: #include
"third_party/skia/include/core/SkColor.h"
This can be removed once the other comment is addressed.

https://chromiumcodereview.appspot.com/2360933002/diff/1/ash/common/system/up...
ash/common/system/update/tray_update.cc:68: return for_menu ?
gfx::kGoogleGreen700 : SK_ColorWHITE;
nit: please use kTrayIconColor.

[yiyix, 2016-09-22 18:31:10]

Committing changes~

https://chromiumcodereview.appspot.com/2360933002/diff/1/ash/common/system/up...
File ash/common/system/update/tray_update.cc (right):

https://chromiumcodereview.appspot.com/2360933002/diff/1/ash/common/system/up...
ash/common/system/update/tray_update.cc:18: #include
"third_party/skia/include/core/SkColor.h"
On 2016/09/22 14:38:20, tdanderson wrote:
> This can be removed once the other comment is addressed.

Done.

https://chromiumcodereview.appspot.com/2360933002/diff/1/ash/common/system/up...
ash/common/system/update/tray_update.cc:68: return for_menu ?
gfx::kGoogleGreen700 : SK_ColorWHITE;
On 2016/09/22 14:38:20, tdanderson wrote:
> nit: please use kTrayIconColor.

I was just checking the constant with color white. I agree that kTrayIconColor
is more descriptive and better.

[yiyix, 2016-09-22 19:37:23]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 19:37:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 20:29:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 20:29:59]

Dry run: This issue passed the CQ dry run.

[yiyix, 2016-09-22 20:32:25]

The CQ bit was checked by yiyix@chromium.org

[yiyix, 2016-09-22 20:32:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2360933002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-09-22 20:33:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 20:40:44]

Description was changed from

==========
Update the color of update button and improve its appearance

Update the vector icon for tray update button, so it looks more 
clear on screen. This cl also updates the color of low severity 
tray update button from green to white. 

BUG=643401, 646570
==========

to

==========
Update the color of update button and improve its appearance

Update the vector icon for tray update button, so it looks more 
clear on screen. This cl also updates the color of low severity 
tray update button from green to white. 

BUG=643401, 646570
==========

[commit-bot: I haz the power, 2016-09-22 20:40:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-22 20:43:34]

Description was changed from

==========
Update the color of update button and improve its appearance

Update the vector icon for tray update button, so it looks more 
clear on screen. This cl also updates the color of low severity 
tray update button from green to white. 

BUG=643401, 646570
==========

to

==========
Update the color of update button and improve its appearance

Update the vector icon for tray update button, so it looks more
clear on screen. This cl also updates the color of low severity
tray update button from green to white.

BUG=643401, 646570

Committed: https://crrev.com/d426dc23088e12be0a3b5a12fc388e5eaa4209d2
Cr-Commit-Position: refs/heads/master@{#420448}
==========

[commit-bot: I haz the power, 2016-09-22 20:43:35]

Patchset 2 (id:??) landed as
https://crrev.com/d426dc23088e12be0a3b5a12fc388e5eaa4209d2
Cr-Commit-Position: refs/heads/master@{#420448}