third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h - Issue 2360913004: Support for multiple block fragments in getClientRects().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

Issue 2360913004: Support for multiple block fragments in getClientRects(). (Closed)

Patch Set: fast/overflow/overflow-height-float-not-removed-crash3.html crashed because saturated LayoutUnits caused zero height Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp ('k') | third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp » ('j') | third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

diff --git a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

index 343c8df31e7f31fcfe940378e79304fa4406e281..fcf5a21235a364abd10c085d69eb0671abae8ca8 100644

--- a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

+++ b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

@@ -67,6 +67,7 @@ public:

LayoutPoint visualPointToFlowThreadPoint(const LayoutPoint& visualPoint) const;

LayoutRect fragmentsBoundingBox(const LayoutRect& boundingBoxInFlowThread) const;

+ LayoutRect flowThreadPortionRectAt(unsigned columnIndex) const;

LayoutRect flowThreadPortionOverflowRectAt(unsigned columnIndex) const;

// Get the first and the last column intersecting the specified block range.

@@ -93,7 +94,6 @@ private:

LayoutRect columnRectAt(unsigned columnIndex) const;

LayoutUnit logicalTopInFlowThreadAt(unsigned columnIndex) const { return m_logicalTopInFlowThread + columnIndex * m_columnHeight; }

- LayoutRect flowThreadPortionRectAt(unsigned columnIndex) const;

// Return the column that the specified visual point belongs to. Only the coordinate on the

// column progression axis is relevant. Every point belongs to a column, even if said point is