Make stdout and stderr async.

runtime/bin/socket_win.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_WINDOWS)
 
 #include "bin/builtin.h"
 #include "bin/eventhandler.h"
 #include "bin/file.h"
@@ skipping 183 matching lines @@
       handle = GetStdHandle(STD_ERROR_HANDLE);
       break;
     default: UNREACHABLE();
   }
   if (handle == INVALID_HANDLE_VALUE) {
     return -1;
   }
   FileHandle* file_handle = new FileHandle(handle);
   if (file_handle == NULL) return -1;
   file_handle->MarkDoesNotSupportOverlappedIO();
+  file_handle->EnsureInitialized(EventHandler::delegate());

[Søren Gjesse, 2013/09/24 11:24:22]

How about getting rid of EnsureInitialized completely?

We can add a static on EventhandlerImplementation with the instance. There is
only one and it needs to be created before anything happens. I think the
event_handler_ member can be removed from the Handle class and we can just use
EventHandlerImplementation::instance_.

You can do that in a separate cl.

[Anders Johnsen, 2013/09/24 11:41:56]

Will do, it would be a nice cleanup.

   return reinterpret_cast<intptr_t>(file_handle);
 }
 
 
 intptr_t ServerSocket::Accept(intptr_t fd) {
   ListenSocket* listen_socket = reinterpret_cast<ListenSocket*>(fd);
   ClientSocket* client_socket = listen_socket->Accept();
   if (client_socket != NULL) {
     return reinterpret_cast<intptr_t>(client_socket);
   } else {
@@ skipping 224 matching lines @@
                     IPPROTO_TCP,
                     TCP_NODELAY,
                     reinterpret_cast<char *>(&on),
                     sizeof(on)) == 0;
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_WINDOWS)