Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 23609037: Add string art GM and sample. (Closed)

Created:
7 years, 3 months ago by jvanverth1
Modified:
7 years, 3 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 10

Patch Set 2 : Fixes for nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -0 lines) Patch
A gm/stringart.cpp View 1 1 chunk +66 lines, -0 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A samplecode/SampleStringArt.cpp View 1 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvanverth1
7 years, 3 months ago (2013-09-12 14:59:58 UTC) #1
robertphillips
lgtm + nits/questions https://codereview.chromium.org/23609037/diff/1/gm/stringart.cpp File gm/stringart.cpp (right): https://codereview.chromium.org/23609037/diff/1/gm/stringart.cpp#newcode13 gm/stringart.cpp:13: Does it need to be this ...
7 years, 3 months ago (2013-09-12 15:19:56 UTC) #2
jvanverth1
https://codereview.chromium.org/23609037/diff/1/gm/stringart.cpp File gm/stringart.cpp (right): https://codereview.chromium.org/23609037/diff/1/gm/stringart.cpp#newcode13 gm/stringart.cpp:13: On 2013/09/12 15:19:56, robertphillips wrote: > Does it need ...
7 years, 3 months ago (2013-09-12 16:55:44 UTC) #3
jvanverth1
7 years, 3 months ago (2013-09-19 15:32:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r11383 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698