Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2190)

Unified Diff: Source/modules/webmidi/MIDIAccess.cpp

Issue 23609033: Web MIDI: MIDIPort doesn't have to be ActiveDOMObject (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: revert idl changes Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/webmidi/MIDIInput.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webmidi/MIDIAccess.cpp
diff --git a/Source/modules/webmidi/MIDIAccess.cpp b/Source/modules/webmidi/MIDIAccess.cpp
index 33c4c336477abf8fda5d0f374ce2ed5310433525..504bf4b0d47b1863fbf8d26e4266b2b53558bbe5 100644
--- a/Source/modules/webmidi/MIDIAccess.cpp
+++ b/Source/modules/webmidi/MIDIAccess.cpp
@@ -80,7 +80,7 @@ void MIDIAccess::didAddInputPort(const String& id, const String& manufacturer, c
{
ASSERT(isMainThread());
- m_inputs.append(MIDIInput::create(this, executionContext(), id, manufacturer, name, version));
+ m_inputs.append(MIDIInput::create(this, id, manufacturer, name, version));
}
void MIDIAccess::didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version)
@@ -88,7 +88,7 @@ void MIDIAccess::didAddOutputPort(const String& id, const String& manufacturer,
ASSERT(isMainThread());
unsigned portIndex = m_outputs.size();
- m_outputs.append(MIDIOutput::create(this, portIndex, executionContext(), id, manufacturer, name, version));
+ m_outputs.append(MIDIOutput::create(this, portIndex, id, manufacturer, name, version));
}
void MIDIAccess::didStartSession(bool success)
@@ -152,8 +152,6 @@ void MIDIAccess::stop()
MIDIController* controller = MIDIController::from(document->page());
ASSERT(controller);
controller->cancelSysExPermissionRequest(this);
-
- m_accessor.clear();
}
void MIDIAccess::startRequest()
« no previous file with comments | « no previous file | Source/modules/webmidi/MIDIInput.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698