Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: runtime/vm/debugger_api_impl_test.cc

Issue 23609032: Add "function" as an argument to Dart_ActivationFrameInfo (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: PTAL Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger_api_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger_api_impl_test.cc
diff --git a/runtime/vm/debugger_api_impl_test.cc b/runtime/vm/debugger_api_impl_test.cc
index 7fc6a6bb3865e0106ae4587da9af3f45a766cdef..2426b3fd64f7c11da63886856b10a5cfa017ec0a 100644
--- a/runtime/vm/debugger_api_impl_test.cc
+++ b/runtime/vm/debugger_api_impl_test.cc
@@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE file.
#include "include/dart_debugger_api.h"
+#include "include/dart_mirrors_api.h"
#include "platform/assert.h"
#include "vm/dart_api_impl.h"
#include "vm/thread.h"
@@ -235,8 +236,9 @@ static void VerifyStackFrame(Dart_ActivationFrame frame,
Dart_Handle expected_locals,
bool skip_null_expects) {
Dart_Handle func_name;
+ Dart_Handle func;
Dart_Handle res;
- res = Dart_ActivationFrameInfo(frame, &func_name, NULL, NULL, NULL);
+ res = Dart_ActivationFrameGetLocation(frame, &func_name, &func, NULL);
EXPECT_TRUE(res);
EXPECT(Dart_IsString(func_name));
const char* func_name_chars;
@@ -244,6 +246,11 @@ static void VerifyStackFrame(Dart_ActivationFrame frame,
if (expected_name != NULL) {
EXPECT_SUBSTRING(expected_name, func_name_chars);
}
+ EXPECT(Dart_IsFunction(func));
+ const char* func_name_chars_from_func_handle;
+ Dart_StringToCString(Dart_FunctionName(func),
+ &func_name_chars_from_func_handle);
+ EXPECT_STREQ(func_name_chars, func_name_chars_from_func_handle);
if (!Dart_IsNull(expected_locals)) {
Dart_Handle locals = Dart_GetLocalVariables(frame);
« no previous file with comments | « runtime/vm/debugger_api_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698