Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 23609031: Make getting the getting number of CPU cores more portable (Closed)

Created:
7 years, 3 months ago by lgombos
Modified:
7 years, 3 months ago
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez, Nico
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Special-case only android and windows platforms and for the default case use sysconf() call to get the number of cores. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157734

Patch Set 1 #

Patch Set 2 : Fix build #

Total comments: 1

Patch Set 3 : Remove OS(ANDROID) branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -28 lines) Patch
M Source/wtf/NumberOfCores.cpp View 1 2 1 chunk +8 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lgombos
Inspired by a comment made by Evan https://codereview.chromium.org/23536039/#msg17 . Similar solution is used now by ...
7 years, 3 months ago (2013-09-12 02:45:51 UTC) #1
Evan Martin
+nico
7 years, 3 months ago (2013-09-12 19:01:30 UTC) #2
Nico
lgtm https://codereview.chromium.org/23609031/diff/3001/Source/wtf/NumberOfCores.cpp File Source/wtf/NumberOfCores.cpp (right): https://codereview.chromium.org/23609031/diff/3001/Source/wtf/NumberOfCores.cpp#newcode47 Source/wtf/NumberOfCores.cpp:47: // FIXME: Can we do better on Android ...
7 years, 3 months ago (2013-09-12 19:34:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23609031/10001
7 years, 3 months ago (2013-09-13 01:58:19 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-13 03:05:46 UTC) #5
Message was sent while issue was closed.
Change committed as 157734

Powered by Google App Engine
This is Rietveld 408576698