Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 23609022: rebaseline hodge podge (Closed)

Created:
7 years, 3 months ago by bsalomon
Modified:
7 years, 3 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com, edisonn
Visibility:
Public.

Description

rebaseline hodge podge Ran rebaseline.py with no args. Reverted one PDF change that I didn't understand: Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release__tilemode_gradient_pdf-mac.png All remaining changes looked equally correct before and after. Looks like some line snapping flakes in the mix, just rebaseling for now since there is a lot in here to sort through. R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=11168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -317 lines) Patch
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 49 chunks +49 lines, -49 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 49 chunks +49 lines, -49 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json View 18 chunks +18 lines, -18 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json View 18 chunks +18 lines, -18 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Debug/expected-results.json View 13 chunks +13 lines, -13 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Release/expected-results.json View 13 chunks +13 lines, -13 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Debug/expected-results.json View 16 chunks +16 lines, -16 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release/expected-results.json View 16 chunks +16 lines, -16 lines 0 comments Download
M expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 33 chunks +33 lines, -33 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 63 chunks +63 lines, -63 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
Attempt at a clean sweep of remaining rebaselines. Most of these are from my two ...
7 years, 3 months ago (2013-09-09 19:35:12 UTC) #1
epoger
LGTM Re Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release__tilemode_gradient_pdf-mac.png : I wonder if this might be a variation on https://code.google.com/p/skia/issues/detail?id=476 ('CGContextDrawPDFPage() ...
7 years, 3 months ago (2013-09-09 19:41:54 UTC) #2
bsalomon
On 2013/09/09 19:41:54, epoger wrote: > LGTM > > Re > Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release__tilemode_gradient_pdf-mac.png : > I ...
7 years, 3 months ago (2013-09-09 19:44:24 UTC) #3
bsalomon
7 years, 3 months ago (2013-09-09 19:45:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r11168 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698