Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 2360893002: Update TestExpectations for removed/renamed tests when updating w3c tests. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, ojan
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, bokan, chromium-reviews, Dirk Pranke, jeffcarp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update TestExpectations for removed/renamed tests when updating w3c tests. This change would make it so that when update-w3c-deps is run, lines in TestExpectations for deleted or renamed tests are updated. I believe that this wouldn't work for lines with directories instead of individual tests as-is, although I think that's a relatively rare case. BUG=649010 Committed: https://crrev.com/809c4145ce868eeb7bbbb6d65d08bc1eac16aaf6 Cr-Commit-Position: refs/heads/master@{#420362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -4 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 5 chunks +57 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
qyearsley
4 years, 3 months ago (2016-09-21 23:40:55 UTC) #2
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-21 23:59:12 UTC) #3
Dirk Pranke
You should make sure that jeffcarp@ is reviewing these, too, so that ojan and I ...
4 years, 3 months ago (2016-09-22 00:00:00 UTC) #4
qyearsley
On 2016/09/22 at 00:00:00, dpranke wrote: > You should make sure that jeffcarp@ is reviewing ...
4 years, 3 months ago (2016-09-22 00:01:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360893002/1
4 years, 3 months ago (2016-09-22 16:07:53 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 16:12:54 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 16:14:37 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/809c4145ce868eeb7bbbb6d65d08bc1eac16aaf6
Cr-Commit-Position: refs/heads/master@{#420362}

Powered by Google App Engine
This is Rietveld 408576698