Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2360863002: Remove ContainerViewObserver class (Closed)

Created:
4 years, 3 months ago by Jinsuk Kim
Modified:
4 years, 3 months ago
Reviewers:
Ted C
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContainerViewObserver class Removes the class left unused after refactoring BUG=624977 Committed: https://crrev.com/e03ab3adcb3134c665843469613c9a7faba46b5b Cr-Commit-Position: refs/heads/master@{#420208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M content/public/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/ContainerViewObserver.java View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Jinsuk Kim
4 years, 3 months ago (2016-09-21 23:46:50 UTC) #6
Ted C
lgtm
4 years, 3 months ago (2016-09-21 23:58:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360863002/1
4 years, 3 months ago (2016-09-22 00:00:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 00:07:25 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 00:31:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e03ab3adcb3134c665843469613c9a7faba46b5b
Cr-Commit-Position: refs/heads/master@{#420208}

Powered by Google App Engine
This is Rietveld 408576698