Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/BUILD.gn

Issue 2360853002: Better handle safe_browsing logic in build dependencies. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 9f3cdeb24dfc42323ac8cb50abb15fff679b73a6..a573d844497fb657bfaafbc03321cebbed85d1ce 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -3920,7 +3920,6 @@ grit("resources") {
deps = [
":chrome_internal_resources_gen",
- "//chrome/browser/resources/safe_browsing:make_file_types_protobuf",
# Depend only on the generated mojo bindings since we read the .mojom.js
# file, rather than the whole mojo target which will link the C++ bindings.
@@ -3931,6 +3930,11 @@ grit("resources") {
"//url/mojo:url_mojom_gurl__generator",
"//url/mojo:url_mojom_origin__generator",
]
+
+ if (safe_browsing_mode > 0) {
+ deps +=
+ [ "//chrome/browser/resources/safe_browsing:make_file_types_protobuf" ]
+ }
}
if (is_chrome_branded) {

Powered by Google App Engine
This is Rietveld 408576698