Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Side by Side Diff: chrome/browser/BUILD.gn

Issue 2360853002: Better handle safe_browsing logic in build dependencies. (Closed)
Patch Set: Use integer comparison in grd file Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/crypto.gni") 6 import("//build/config/crypto.gni")
7 import("//build/config/features.gni") 7 import("//build/config/features.gni")
8 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
9 import("//build/split_static_library.gni") 9 import("//build/split_static_library.gni")
10 import("//chrome/common/features.gni") 10 import("//chrome/common/features.gni")
(...skipping 3904 matching lines...) Expand 10 before | Expand all | Expand 10 after
3915 grit_flags = [ 3915 grit_flags = [
3916 "-E", 3916 "-E",
3917 "additional_modules_list_file=" + 3917 "additional_modules_list_file=" +
3918 rebase_path(additional_modules_list_file, root_build_dir), 3918 rebase_path(additional_modules_list_file, root_build_dir),
3919 "-E", 3919 "-E",
3920 "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir), 3920 "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir),
3921 ] 3921 ]
3922 3922
3923 deps = [ 3923 deps = [
3924 ":chrome_internal_resources_gen", 3924 ":chrome_internal_resources_gen",
3925 "//chrome/browser/resources/safe_browsing:make_file_types_protobuf",
3926 3925
3927 # Depend only on the generated mojo bindings since we read the .mojom.js 3926 # Depend only on the generated mojo bindings since we read the .mojom.js
3928 # file, rather than the whole mojo target which will link the C++ bindings. 3927 # file, rather than the whole mojo target which will link the C++ bindings.
3929 "//chrome/browser/ui/webui/engagement:mojo_bindings__generator", 3928 "//chrome/browser/ui/webui/engagement:mojo_bindings__generator",
3930 "//chrome/browser/ui/webui/omnibox:mojo_bindings__generator", 3929 "//chrome/browser/ui/webui/omnibox:mojo_bindings__generator",
3931 "//chrome/browser/ui/webui/plugins:mojo_bindings__generator", 3930 "//chrome/browser/ui/webui/plugins:mojo_bindings__generator",
3932 "//chrome/browser/ui/webui/usb_internals:mojo_bindings__generator", 3931 "//chrome/browser/ui/webui/usb_internals:mojo_bindings__generator",
3933 "//url/mojo:url_mojom_gurl__generator", 3932 "//url/mojo:url_mojom_gurl__generator",
3934 "//url/mojo:url_mojom_origin__generator", 3933 "//url/mojo:url_mojom_origin__generator",
3935 ] 3934 ]
3935
3936 if (safe_browsing_mode > 0) {
3937 deps +=
3938 [ "//chrome/browser/resources/safe_browsing:make_file_types_protobuf" ]
3939 }
3936 } 3940 }
3937 3941
3938 if (is_chrome_branded) { 3942 if (is_chrome_branded) {
3939 action("chrome_internal_resources_gen") { 3943 action("chrome_internal_resources_gen") {
3940 script = "internal/transform_additional_modules_list.py" 3944 script = "internal/transform_additional_modules_list.py"
3941 sources = [ 3945 sources = [
3942 "internal/resources/additional_modules_list.input", 3946 "internal/resources/additional_modules_list.input",
3943 ] 3947 ]
3944 outputs = [ 3948 outputs = [
3945 additional_modules_list_file, 3949 additional_modules_list_file,
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
4241 # linking all of the test support. 4245 # linking all of the test support.
4242 static_library("pepper_cdm_test_constants") { 4246 static_library("pepper_cdm_test_constants") {
4243 testonly = true 4247 testonly = true
4244 visibility = [ "//chrome/*" ] 4248 visibility = [ "//chrome/*" ]
4245 sources = [ 4249 sources = [
4246 "media/pepper_cdm_test_constants.cc", 4250 "media/pepper_cdm_test_constants.cc",
4247 "media/pepper_cdm_test_constants.h", 4251 "media/pepper_cdm_test_constants.h",
4248 ] 4252 ]
4249 } 4253 }
4250 } 4254 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698