Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Side by Side Diff: chrome/browser/BUILD.gn

Issue 2360853002: Better handle safe_browsing logic in build dependencies. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/crypto.gni") 6 import("//build/config/crypto.gni")
7 import("//build/config/features.gni") 7 import("//build/config/features.gni")
8 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
9 import("//build/split_static_library.gni") 9 import("//build/split_static_library.gni")
10 import("//chrome/common/features.gni") 10 import("//chrome/common/features.gni")
(...skipping 3902 matching lines...) Expand 10 before | Expand all | Expand 10 after
3913 grit_flags = [ 3913 grit_flags = [
3914 "-E", 3914 "-E",
3915 "additional_modules_list_file=" + 3915 "additional_modules_list_file=" +
3916 rebase_path(additional_modules_list_file, root_build_dir), 3916 rebase_path(additional_modules_list_file, root_build_dir),
3917 "-E", 3917 "-E",
3918 "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir), 3918 "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir),
3919 ] 3919 ]
3920 3920
3921 deps = [ 3921 deps = [
3922 ":chrome_internal_resources_gen", 3922 ":chrome_internal_resources_gen",
3923 "//chrome/browser/resources/safe_browsing:make_file_types_protobuf",
3924 3923
3925 # Depend only on the generated mojo bindings since we read the .mojom.js 3924 # Depend only on the generated mojo bindings since we read the .mojom.js
3926 # file, rather than the whole mojo target which will link the C++ bindings. 3925 # file, rather than the whole mojo target which will link the C++ bindings.
3927 "//chrome/browser/ui/webui/engagement:mojo_bindings__generator", 3926 "//chrome/browser/ui/webui/engagement:mojo_bindings__generator",
3928 "//chrome/browser/ui/webui/omnibox:mojo_bindings__generator", 3927 "//chrome/browser/ui/webui/omnibox:mojo_bindings__generator",
3929 "//chrome/browser/ui/webui/plugins:mojo_bindings__generator", 3928 "//chrome/browser/ui/webui/plugins:mojo_bindings__generator",
3930 "//chrome/browser/ui/webui/usb_internals:mojo_bindings__generator", 3929 "//chrome/browser/ui/webui/usb_internals:mojo_bindings__generator",
3931 "//url/mojo:url_mojom_gurl__generator", 3930 "//url/mojo:url_mojom_gurl__generator",
3932 "//url/mojo:url_mojom_origin__generator", 3931 "//url/mojo:url_mojom_origin__generator",
3933 ] 3932 ]
3933
3934 if (safe_browsing_mode > 0) {
3935 deps +=
3936 [ "//chrome/browser/resources/safe_browsing:make_file_types_protobuf" ]
3937 }
3934 } 3938 }
3935 3939
3936 if (is_chrome_branded) { 3940 if (is_chrome_branded) {
3937 action("chrome_internal_resources_gen") { 3941 action("chrome_internal_resources_gen") {
3938 script = "internal/transform_additional_modules_list.py" 3942 script = "internal/transform_additional_modules_list.py"
3939 sources = [ 3943 sources = [
3940 "internal/resources/additional_modules_list.input", 3944 "internal/resources/additional_modules_list.input",
3941 ] 3945 ]
3942 outputs = [ 3946 outputs = [
3943 additional_modules_list_file, 3947 additional_modules_list_file,
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
4239 # linking all of the test support. 4243 # linking all of the test support.
4240 static_library("pepper_cdm_test_constants") { 4244 static_library("pepper_cdm_test_constants") {
4241 testonly = true 4245 testonly = true
4242 visibility = [ "//chrome/*" ] 4246 visibility = [ "//chrome/*" ]
4243 sources = [ 4247 sources = [
4244 "media/pepper_cdm_test_constants.cc", 4248 "media/pepper_cdm_test_constants.cc",
4245 "media/pepper_cdm_test_constants.h", 4249 "media/pepper_cdm_test_constants.h",
4246 ] 4250 ]
4247 } 4251 }
4248 } 4252 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698