Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: build/config/features.gni

Issue 2360853002: Better handle safe_browsing logic in build dependencies. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | chrome/common/features.gni » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # ============================================= 5 # =============================================
6 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE 6 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE
7 # ============================================= 7 # =============================================
8 # 8 #
9 # These flags are effectively global. Your feature flag should go near the 9 # These flags are effectively global. Your feature flag should go near the
10 # code it controls. Most of these items are here now because they control 10 # code it controls. Most of these items are here now because they control
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 enable_browser_cdms = is_android || is_chromecast 72 enable_browser_cdms = is_android || is_chromecast
73 73
74 # Hangout services is an extension that adds extra features to Hangouts. 74 # Hangout services is an extension that adds extra features to Hangouts.
75 # For official GYP builds, this flag is set. 75 # For official GYP builds, this flag is set.
76 enable_hangout_services_extension = false 76 enable_hangout_services_extension = false
77 77
78 # Variable safe_browsing is used to control the build time configuration for 78 # Variable safe_browsing is used to control the build time configuration for
79 # safe browsing feature. Safe browsing can be compiled in 3 different levels: 79 # safe browsing feature. Safe browsing can be compiled in 3 different levels:
80 # 0 disables it, 1 enables it fully, and 2 enables mobile protection via an 80 # 0 disables it, 1 enables it fully, and 2 enables mobile protection via an
81 # external API. 81 # external API.
82 if (is_android) { 82 if (is_ios || is_chromecast) {
83 safe_browsing_mode = 0
84 } else if (is_android) {
83 safe_browsing_mode = 2 85 safe_browsing_mode = 2
84 } else if (is_ios || is_chromecast) {
85 safe_browsing_mode = 0
86 } else { 86 } else {
87 safe_browsing_mode = 1 87 safe_browsing_mode = 1
88 } 88 }
89 89
90 # Set to true make a build that disables activation of field trial tests 90 # Set to true make a build that disables activation of field trial tests
91 # specified in testing/variations/fieldtrial_testing_config_*.json. 91 # specified in testing/variations/fieldtrial_testing_config_*.json.
92 # Note: this setting is ignored if is_chrome_branded. 92 # Note: this setting is ignored if is_chrome_branded.
93 fieldtrial_testing_like_official_build = is_chrome_branded 93 fieldtrial_testing_like_official_build = is_chrome_branded
94 94
95 use_cups = (is_desktop_linux || is_mac) && !is_chromecast 95 use_cups = (is_desktop_linux || is_mac) && !is_chromecast
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 178
179 enable_configuration_policy = !is_ios 179 enable_configuration_policy = !is_ios
180 180
181 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build 181 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build
182 # 182 #
183 # ============================================= 183 # =============================================
184 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE 184 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE
185 # ============================================= 185 # =============================================
186 # 186 #
187 # See comment at the top. 187 # See comment at the top.
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | chrome/common/features.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698