Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 236083009: Fix lint error in TimelinePanel.js due to 'energy' variable. (Closed)

Created:
6 years, 8 months ago by jbroman
Modified:
6 years, 8 months ago
Reviewers:
caseq, Pan, alph, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix lint error in TimelinePanel.js due to 'energy' variable. This error was introduced in: https://codereview.chromium.org/220963002 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/TimelinePanel.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
jbroman
Not sure why the presubmit hook didn't catch this originally, but it nagged me when ...
6 years, 8 months ago (2014-04-13 18:17:11 UTC) #1
alph
lgtm
6 years, 8 months ago (2014-04-13 19:42:36 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 8 months ago (2014-04-14 06:18:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/236083009/1
6 years, 8 months ago (2014-04-14 06:18:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 06:29:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-14 06:29:48 UTC) #6
caseq
lgtm
6 years, 8 months ago (2014-04-14 07:35:07 UTC) #7
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 8 months ago (2014-04-14 07:35:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/236083009/1
6 years, 8 months ago (2014-04-14 07:35:33 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 07:45:02 UTC) #10
Message was sent while issue was closed. 
Change committed as 171434

Powered by Google App Engine
This is Rietveld 408576698