Issue 236083003: Use document's contentSize when the HTML element is selected.

Issue 236083003: Use document's contentSize when the HTML element is selected. (Closed)

Created:
6 years, 8 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 8 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, jdduke (slow)

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Use document's contentSize when the HTML element is selected. HTMLHtmlElement's size might not be the size of the document, such as HTMLBodyElement's size, so when the selection root in the html element, the best thing we can do is get the size of the content because <html> and <body> might have a different size. BUG=361927 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171441

Patch Set 1 #

Patch Set 2 : cleaned, with tests #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -4 lines)			Patch
M	Source/web/WebViewImpl.cpp	View	1 2 3	1 chunk	+4 lines, -1 line	0 comments	Download
M	Source/web/tests/WebViewTest.cpp	View	1 2	2 chunks	+26 lines, -1 line	0 comments	Download
A +	Source/web/tests/data/select_range_basic_broken_height.html	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mlamouri (slow - plz ping)

This is a regression in Beta, it would be great if you could prioritize the ...

6 years, 8 months ago (2014-04-13 00:28:54 UTC) #1

jochen (gone - plz use gerrit)

lgtm https://codereview.chromium.org/236083003/diff/20001/Source/web/WebViewImpl.cpp File Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/236083003/diff/20001/Source/web/WebViewImpl.cpp#newcode2198 Source/web/WebViewImpl.cpp:2198: unrelated change?

6 years, 8 months ago (2014-04-14 07:12:16 UTC) #2

mlamouri (slow - plz ping)

https://codereview.chromium.org/236083003/diff/20001/Source/web/WebViewImpl.cpp File Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/236083003/diff/20001/Source/web/WebViewImpl.cpp#newcode2198 Source/web/WebViewImpl.cpp:2198: On 2014/04/14 07:12:16, jochen wrote: > unrelated change? Removed.

6 years, 8 months ago (2014-04-14 07:25:54 UTC) #3

mlamouri (slow - plz ping)

The CQ bit was checked by mlamouri@chromium.org

6 years, 8 months ago (2014-04-14 07:26:05 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/236083003/40001

6 years, 8 months ago (2014-04-14 07:26:17 UTC) #5

Message was sent while issue was closed.

Change committed as 171441

Expand Messages | Collapse Messages