components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java - Issue 2360813003: [Cronet] Pass metrics information from C++ BidirectionalStream to Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

Issue 2360813003: [Cronet] Pass metrics information from C++ BidirectionalStream to Java (Closed)

Patch Set: Rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

index 2c2df1a7f1d23f066c66f28f65a24e6277e7c477..2380efb9fa079bfa5bc6e41ae97068c26159c07a 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

@@ -210,9 +210,13 @@ public class CronetUrlRequestContext extends CronetEngine {

boolean delayRequestHeadersUntilFirstFlush, Collection<Object> requestAnnotations) {

synchronized (mLock) {

checkHaveAdapter();

+ boolean metricsCollectionEnabled = false;

+ synchronized (mFinishedListenerLock) {

+ metricsCollectionEnabled = !mFinishedListenerList.isEmpty();

+ }

return new CronetBidirectionalStream(this, url, priority, callback, executor,

httpMethod, requestHeaders, delayRequestHeadersUntilFirstFlush,

- requestAnnotations);

+ requestAnnotations, metricsCollectionEnabled);

}