Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: chrome/browser/ui/views/frame/browser_view_unittest.cc

Issue 2360803002: Remove some pre-MD code from toolbar/tabstrip/frame. (Closed)
Patch Set: pkasting review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view_unittest.cc
diff --git a/chrome/browser/ui/views/frame/browser_view_unittest.cc b/chrome/browser/ui/views/frame/browser_view_unittest.cc
index a7d35312a0bcaf6b8e2dad797adf0d841dfb2d36..897dd0cfb157fc10c7720b592342ba7d9e5d7092 100644
--- a/chrome/browser/ui/views/frame/browser_view_unittest.cc
+++ b/chrome/browser/ui/views/frame/browser_view_unittest.cc
@@ -96,8 +96,7 @@ TEST_F(BrowserViewTest, BrowserViewLayout) {
EXPECT_EQ(expected_tabstrip_origin.x(), tabstrip->x());
EXPECT_EQ(expected_tabstrip_origin.y(), tabstrip->y());
EXPECT_EQ(0, toolbar->x());
- const int overlap = GetLayoutConstant(TABSTRIP_TOOLBAR_OVERLAP);
- EXPECT_EQ(tabstrip->bounds().bottom() - overlap, toolbar->y());
+ EXPECT_EQ(tabstrip->bounds().bottom(), toolbar->y());
EXPECT_EQ(0, contents_container->x());
EXPECT_EQ(toolbar->bounds().bottom(), contents_container->y());
EXPECT_EQ(top_container->bounds().bottom(), contents_container->y());
@@ -136,10 +135,9 @@ TEST_F(BrowserViewTest, BrowserViewLayout) {
// Bookmark bar layout on NTP.
EXPECT_EQ(0, bookmark_bar->x());
- EXPECT_EQ(
- tabstrip->bounds().bottom() + toolbar->height() - overlap -
- views::NonClientFrameView::kClientEdgeThickness,
- bookmark_bar->y());
+ EXPECT_EQ(tabstrip->bounds().bottom() + toolbar->height() -
+ views::NonClientFrameView::kClientEdgeThickness,
+ bookmark_bar->y());
EXPECT_EQ(toolbar->bounds().bottom(), contents_container->y());
// Contents view has a "top margin" pushing it below the bookmark bar.
EXPECT_EQ(bookmark_bar->height() -
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view_layout.cc ('k') | chrome/browser/ui/views/frame/glass_browser_frame_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698