Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/browser/themes/browser_theme_pack.cc

Issue 2360803002: Remove some pre-MD code from toolbar/tabstrip/frame. (Closed)
Patch Set: pkasting review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/theme/theme_resources.grd ('k') | chrome/browser/themes/theme_properties.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/themes/browser_theme_pack.h" 5 #include "chrome/browser/themes/browser_theme_pack.h"
6 6
7 #include <limits.h> 7 #include <limits.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <limits> 10 #include <limits>
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 const char* const key; 100 const char* const key;
101 }; 101 };
102 102
103 // IDR_* resource names change whenever new resources are added; use persistent 103 // IDR_* resource names change whenever new resources are added; use persistent
104 // IDs when storing to a cached pack. 104 // IDs when storing to a cached pack.
105 // 105 //
106 // TODO(erg): The cocoa port is the last user of the IDR_*_[HP] variants. These 106 // TODO(erg): The cocoa port is the last user of the IDR_*_[HP] variants. These
107 // should be removed once the cocoa port no longer uses them. 107 // should be removed once the cocoa port no longer uses them.
108 PersistingImagesTable kPersistingImages[] = { 108 PersistingImagesTable kPersistingImages[] = {
109 {PRS_THEME_FRAME, IDR_THEME_FRAME, "theme_frame"}, 109 {PRS_THEME_FRAME, IDR_THEME_FRAME, "theme_frame"},
110 {PRS_THEME_FRAME_INACTIVE, 110 {PRS_THEME_FRAME_INACTIVE, IDR_THEME_FRAME_INACTIVE,
111 IDR_THEME_FRAME_INACTIVE,
112 "theme_frame_inactive"}, 111 "theme_frame_inactive"},
113 {PRS_THEME_FRAME_INCOGNITO, 112 {PRS_THEME_FRAME_INCOGNITO, IDR_THEME_FRAME_INCOGNITO,
114 IDR_THEME_FRAME_INCOGNITO,
115 "theme_frame_incognito"}, 113 "theme_frame_incognito"},
116 {PRS_THEME_FRAME_INCOGNITO_INACTIVE, 114 {PRS_THEME_FRAME_INCOGNITO_INACTIVE, IDR_THEME_FRAME_INCOGNITO_INACTIVE,
117 IDR_THEME_FRAME_INCOGNITO_INACTIVE,
118 "theme_frame_incognito_inactive"}, 115 "theme_frame_incognito_inactive"},
119 {PRS_THEME_TOOLBAR, IDR_THEME_TOOLBAR, "theme_toolbar"}, 116 {PRS_THEME_TOOLBAR, IDR_THEME_TOOLBAR, "theme_toolbar"},
120 {PRS_THEME_TAB_BACKGROUND, 117 {PRS_THEME_TAB_BACKGROUND, IDR_THEME_TAB_BACKGROUND,
121 IDR_THEME_TAB_BACKGROUND,
122 "theme_tab_background"}, 118 "theme_tab_background"},
123 #if !defined(OS_MACOSX) 119 #if !defined(OS_MACOSX)
124 {PRS_THEME_TAB_BACKGROUND_INCOGNITO, 120 {PRS_THEME_TAB_BACKGROUND_INCOGNITO, IDR_THEME_TAB_BACKGROUND_INCOGNITO,
125 IDR_THEME_TAB_BACKGROUND_INCOGNITO,
126 "theme_tab_background_incognito"}, 121 "theme_tab_background_incognito"},
127 #endif 122 #endif
128 {PRS_THEME_TAB_BACKGROUND_V, 123 {PRS_THEME_TAB_BACKGROUND_V, IDR_THEME_TAB_BACKGROUND_V,
129 IDR_THEME_TAB_BACKGROUND_V,
130 "theme_tab_background_v"}, 124 "theme_tab_background_v"},
131 {PRS_THEME_NTP_BACKGROUND, 125 {PRS_THEME_NTP_BACKGROUND, IDR_THEME_NTP_BACKGROUND,
132 IDR_THEME_NTP_BACKGROUND,
133 "theme_ntp_background"}, 126 "theme_ntp_background"},
134 {PRS_THEME_FRAME_OVERLAY, IDR_THEME_FRAME_OVERLAY, "theme_frame_overlay"}, 127 {PRS_THEME_FRAME_OVERLAY, IDR_THEME_FRAME_OVERLAY, "theme_frame_overlay"},
135 {PRS_THEME_FRAME_OVERLAY_INACTIVE, 128 {PRS_THEME_FRAME_OVERLAY_INACTIVE, IDR_THEME_FRAME_OVERLAY_INACTIVE,
136 IDR_THEME_FRAME_OVERLAY_INACTIVE,
137 "theme_frame_overlay_inactive"}, 129 "theme_frame_overlay_inactive"},
138 {PRS_THEME_BUTTON_BACKGROUND, 130 {PRS_THEME_BUTTON_BACKGROUND, IDR_THEME_BUTTON_BACKGROUND,
139 IDR_THEME_BUTTON_BACKGROUND,
140 "theme_button_background"}, 131 "theme_button_background"},
141 {PRS_THEME_NTP_ATTRIBUTION, 132 {PRS_THEME_NTP_ATTRIBUTION, IDR_THEME_NTP_ATTRIBUTION,
142 IDR_THEME_NTP_ATTRIBUTION,
143 "theme_ntp_attribution"}, 133 "theme_ntp_attribution"},
144 {PRS_THEME_WINDOW_CONTROL_BACKGROUND, 134 {PRS_THEME_WINDOW_CONTROL_BACKGROUND, IDR_THEME_WINDOW_CONTROL_BACKGROUND,
145 IDR_THEME_WINDOW_CONTROL_BACKGROUND,
146 "theme_window_control_background"}, 135 "theme_window_control_background"},
147 136
148 // The rest of these entries have no key because they can't be overridden 137 // The rest of these entries have no key because they can't be overridden
149 // from the json manifest. 138 // from the json manifest.
150 {15, IDR_BACK, NULL}, 139 {15, IDR_BACK, NULL},
151 {16, IDR_BACK_D, NULL}, 140 {16, IDR_BACK_D, NULL},
152 {17, IDR_BACK_H, NULL}, 141 {17, IDR_BACK_H, NULL},
153 {18, IDR_BACK_P, NULL}, 142 {18, IDR_BACK_P, NULL},
154 {19, IDR_FORWARD, NULL}, 143 {19, IDR_FORWARD, NULL},
155 {20, IDR_FORWARD_D, NULL}, 144 {20, IDR_FORWARD_D, NULL},
156 {21, IDR_FORWARD_H, NULL}, 145 {21, IDR_FORWARD_H, NULL},
157 {22, IDR_FORWARD_P, NULL}, 146 {22, IDR_FORWARD_P, NULL},
147 #if defined(OS_MACOSX)
158 {23, IDR_HOME, NULL}, 148 {23, IDR_HOME, NULL},
159 {24, IDR_HOME_H, NULL}, 149 {24, IDR_HOME_H, NULL},
160 {25, IDR_HOME_P, NULL}, 150 {25, IDR_HOME_P, NULL},
151 #endif
161 {26, IDR_RELOAD, NULL}, 152 {26, IDR_RELOAD, NULL},
162 {27, IDR_RELOAD_H, NULL}, 153 {27, IDR_RELOAD_H, NULL},
163 {28, IDR_RELOAD_P, NULL}, 154 {28, IDR_RELOAD_P, NULL},
164 {29, IDR_STOP, NULL}, 155 {29, IDR_STOP, NULL},
165 {30, IDR_STOP_D, NULL}, 156 {30, IDR_STOP_D, NULL},
166 {31, IDR_STOP_H, NULL}, 157 {31, IDR_STOP_H, NULL},
167 {32, IDR_STOP_P, NULL}, 158 {32, IDR_STOP_P, NULL},
168 {33, IDR_TOOLS, NULL}, 159 {33, IDR_TOOLS, NULL},
169 {34, IDR_TOOLS_H, NULL}, 160 {34, IDR_TOOLS_H, NULL},
170 {35, IDR_TOOLS_P, NULL}, 161 {35, IDR_TOOLS_P, NULL},
(...skipping 1370 matching lines...) Expand 10 before | Expand all | Expand 10 after
1541 false, 1532 false,
1542 &bitmap_data)) { 1533 &bitmap_data)) {
1543 NOTREACHED() << "Unable to encode theme image for prs_id=" 1534 NOTREACHED() << "Unable to encode theme image for prs_id="
1544 << prs_id << " for scale_factor=" << scale_factors_[i]; 1535 << prs_id << " for scale_factor=" << scale_factors_[i];
1545 break; 1536 break;
1546 } 1537 }
1547 image_memory_[scaled_raw_id] = 1538 image_memory_[scaled_raw_id] =
1548 base::RefCountedBytes::TakeVector(&bitmap_data); 1539 base::RefCountedBytes::TakeVector(&bitmap_data);
1549 } 1540 }
1550 } 1541 }
OLDNEW
« no previous file with comments | « chrome/app/theme/theme_resources.grd ('k') | chrome/browser/themes/theme_properties.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698