Issue 23608009: NULL out the buffer in the Vector<T, inline> destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23608009: NULL out the buffer in the Vector<T, inline> destructor. (Closed)

Created:
7 years, 3 months ago by Chris Evans

Modified:
7 years, 3 months ago

Reviewers:
Tom Sepez, abarth-chromium

CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

NULL out the buffer in the Vector<T, inline> destructor. This is a subset of previously reviewed CL, https://codereview.chromium.org/23531010/ that had to be reverted due to unknown reasons for a performance regression. Hence, relanding in pieces. BUG=270545 R=abarth@chromium.org, tsepez@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157409

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	Source/wtf/Vector.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r157409.

Expand Messages | Collapse Messages