Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2360793002: [layoutng] Add border and padding when setting the override size (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Add border and padding when setting the override size This is necessary to avoid a DCHECK when opening the DOM inspector on any page (and is also clearly correct) R=mstensho@chromium.org,eae@chromium.org BUG=635619 Committed: https://crrev.com/5c2fc8168fc1adeb0029025c6b88b87bc84699d6 Cr-Commit-Position: refs/heads/master@{#420480}

Patch Set 1 #

Total comments: 7

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
cbiesinger
4 years, 3 months ago (2016-09-21 21:05:06 UTC) #1
cbiesinger1
4 years, 3 months ago (2016-09-21 21:12:25 UTC) #5
mstensho (USE GERRIT)
https://codereview.chromium.org/2360793002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc (right): https://codereview.chromium.org/2360793002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc#newcode78 third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc:78: container_logical_width = Above, in normal cases, we set container_logical_width ...
4 years, 3 months ago (2016-09-22 07:11:46 UTC) #8
cbiesinger
https://codereview.chromium.org/2360793002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc (right): https://codereview.chromium.org/2360793002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc#newcode78 third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc:78: container_logical_width = On 2016/09/22 07:11:46, mstensho wrote: > Above, ...
4 years, 3 months ago (2016-09-22 16:19:46 UTC) #9
mstensho (USE GERRIT)
lgtm https://codereview.chromium.org/2360793002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc (right): https://codereview.chromium.org/2360793002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc#newcode78 third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc:78: container_logical_width = On 2016/09/22 16:19:46, cbiesinger wrote: > ...
4 years, 3 months ago (2016-09-22 16:49:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360793002/20001
4 years, 3 months ago (2016-09-22 16:56:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/297841)
4 years, 3 months ago (2016-09-22 18:29:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360793002/20001
4 years, 3 months ago (2016-09-22 18:34:45 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 22:20:01 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 22:22:14 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c2fc8168fc1adeb0029025c6b88b87bc84699d6
Cr-Commit-Position: refs/heads/master@{#420480}

Powered by Google App Engine
This is Rietveld 408576698