More kernel_impact.

More kernel_impact.

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/3d533a08f2bcc15ebc4d10f489a2913c3d55bdbd

[Johnni Winther, 2016-09-22 13:30:08]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-09-22 19:20:15]

lgtm

Also, give this cl a more descriptive message, something like "Add local
functions to kernel impact"?

https://codereview.chromium.org/2360773003/diff/1/pkg/compiler/lib/src/serial...
File pkg/compiler/lib/src/serialization/equivalence.dart (right):

https://codereview.chromium.org/2360773003/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/equivalence.dart:519: return
strategy.test(element1, element2, 'name', element1.name, element2.name) &&
checkMembers(element1.memberContext, element2.memberContext);
long lines

https://codereview.chromium.org/2360773003/diff/1/pkg/compiler/lib/src/ssa/ke...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2360773003/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:209:
visitType(node.returnType),
long lines

https://codereview.chromium.org/2360773003/diff/1/pkg/compiler/lib/src/ssa/ke...
File pkg/compiler/lib/src/ssa/kernel_impact.dart (right):

https://codereview.chromium.org/2360773003/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_impact.dart:106: void visitNode(ir.Node node) =>
node?.accept(this);
if you have this, you should use it consistently throughout the visitor. i.e.,
no instances of x.accept(this)

[Johnni Winther, 2016-09-23 09:01:50]

https://codereview.chromium.org/2360773003/diff/1/pkg/compiler/lib/src/serial...
File pkg/compiler/lib/src/serialization/equivalence.dart (right):

https://codereview.chromium.org/2360773003/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/equivalence.dart:519: return
strategy.test(element1, element2, 'name', element1.name, element2.name) &&
checkMembers(element1.memberContext, element2.memberContext);
On 2016/09/22 19:20:15, Harry Terkelsen wrote:
> long lines

Done.

https://codereview.chromium.org/2360773003/diff/1/pkg/compiler/lib/src/ssa/ke...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2360773003/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:209:
visitType(node.returnType),
On 2016/09/22 19:20:15, Harry Terkelsen wrote:
> long lines

Done.

https://codereview.chromium.org/2360773003/diff/1/pkg/compiler/lib/src/ssa/ke...
File pkg/compiler/lib/src/ssa/kernel_impact.dart (right):

https://codereview.chromium.org/2360773003/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_impact.dart:106: void visitNode(ir.Node node) =>
node?.accept(this);
On 2016/09/22 19:20:15, Harry Terkelsen wrote:
> if you have this, you should use it consistently throughout the visitor. i.e.,
> no instances of x.accept(this)

I thought I had ;) - Done.

[Johnni Winther, 2016-09-23 09:02:09]

Description was changed from

==========
More kernel_impact.
==========

to

==========
More kernel_impact.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3d533a08f2bcc15ebc4d10f489a2913c3d55bdbd
==========

[Johnni Winther, 2016-09-23 09:02:10]

Committed patchset #2 (id:20001) manually as
3d533a08f2bcc15ebc4d10f489a2913c3d55bdbd (presubmit successful).