Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 236073004: Remove kEnableBrowserPluginForAllViewTypes flag (Closed)

Created:
6 years, 8 months ago by Zachary Kuznia
Modified:
6 years, 7 months ago
Reviewers:
Fady Samuel, jam
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, jochen+watch_chromium.org, creis+watch_chromium.org
Visibility:
Public.

Description

Remove kEnableBrowserPluginForAllViewTypes flag BUG=362796 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266783

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : Fix tests #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -36 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/startup/bad_flags_prompt.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.cc View 1 2 2 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 29 (0 generated)
Zachary Kuznia
Please take a look.
6 years, 8 months ago (2014-04-11 23:35:37 UTC) #1
jam
lgtm
6 years, 8 months ago (2014-04-11 23:43:03 UTC) #2
Fady Samuel
https://codereview.chromium.org/236073004/diff/1/content/shell/renderer/shell_content_renderer_client.cc File content/shell/renderer/shell_content_renderer_client.cc (left): https://codereview.chromium.org/236073004/diff/1/content/shell/renderer/shell_content_renderer_client.cc#oldcode181 content/shell/renderer/shell_content_renderer_client.cc:181: return ContentRendererClient::AllowBrowserPlugin(container); Do the tests content_browsertests BrowserPluginHostTest.* and BrowserPlugin.* ...
6 years, 8 months ago (2014-04-12 15:49:10 UTC) #3
Zachary Kuznia
https://codereview.chromium.org/236073004/diff/1/content/shell/renderer/shell_content_renderer_client.cc File content/shell/renderer/shell_content_renderer_client.cc (left): https://codereview.chromium.org/236073004/diff/1/content/shell/renderer/shell_content_renderer_client.cc#oldcode181 content/shell/renderer/shell_content_renderer_client.cc:181: return ContentRendererClient::AllowBrowserPlugin(container); On 2014/04/12 15:49:10, Fady Samuel wrote: > ...
6 years, 8 months ago (2014-04-16 23:53:38 UTC) #4
Zachary Kuznia
On 2014/04/16 23:53:38, Zachary Kuznia wrote: > https://codereview.chromium.org/236073004/diff/1/content/shell/renderer/shell_content_renderer_client.cc > File content/shell/renderer/shell_content_renderer_client.cc (left): > > https://codereview.chromium.org/236073004/diff/1/content/shell/renderer/shell_content_renderer_client.cc#oldcode181 ...
6 years, 8 months ago (2014-04-24 19:53:38 UTC) #5
Fady Samuel
lgtm
6 years, 8 months ago (2014-04-24 19:55:47 UTC) #6
Zachary Kuznia
The CQ bit was checked by zork@chromium.org
6 years, 8 months ago (2014-04-24 21:08:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/236073004/40001
6 years, 8 months ago (2014-04-24 21:45:23 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 23:09:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 23:09:30 UTC) #10
Zachary Kuznia
The CQ bit was checked by zork@chromium.org
6 years, 8 months ago (2014-04-25 20:44:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/236073004/40001
6 years, 8 months ago (2014-04-25 21:43:52 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 23:19:38 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-25 23:19:38 UTC) #14
Zachary Kuznia
The CQ bit was checked by zork@chromium.org
6 years, 7 months ago (2014-04-28 21:11:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/236073004/60001
6 years, 7 months ago (2014-04-28 21:12:20 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:17:13 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_aosp
6 years, 7 months ago (2014-04-28 22:17:13 UTC) #18
Zachary Kuznia
The CQ bit was checked by zork@chromium.org
6 years, 7 months ago (2014-04-28 22:18:04 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/236073004/60001
6 years, 7 months ago (2014-04-28 22:18:43 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:27:07 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 22:27:08 UTC) #22
Zachary Kuznia
The CQ bit was checked by zork@chromium.org
6 years, 7 months ago (2014-04-28 22:28:58 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/236073004/60001
6 years, 7 months ago (2014-04-28 22:30:50 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 23:27:14 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 23:27:14 UTC) #26
Zachary Kuznia
The CQ bit was checked by zork@chromium.org
6 years, 7 months ago (2014-04-29 00:24:01 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/236073004/60001
6 years, 7 months ago (2014-04-29 00:25:25 UTC) #28
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 07:59:00 UTC) #29
Message was sent while issue was closed. 
Change committed as 266783

Powered by Google App Engine
This is Rietveld 408576698