Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2360723002: Ntp: add ripple to suggestion cards. (Closed)

Created:
4 years, 3 months ago by Michael van Ouwerkerk
Modified:
4 years, 3 months ago
Reviewers:
Theresa
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ntp: add ripple to suggestion cards. BUG=614320 Committed: https://crrev.com/fc62aaa42d269698b603f59ac868a89a4f8847eb Cr-Commit-Position: refs/heads/master@{#420589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/res/layout/new_tab_page_snippets_card.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 3 months ago (2016-09-21 16:42:05 UTC) #4
Michael van Ouwerkerk
Theresa, could you take a look please, as Bernhard is OOO?
4 years, 3 months ago (2016-09-22 10:08:33 UTC) #8
Theresa
lgtm
4 years, 3 months ago (2016-09-22 17:02:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360723002/1
4 years, 3 months ago (2016-09-23 08:59:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 11:26:50 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 11:29:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc62aaa42d269698b603f59ac868a89a4f8847eb
Cr-Commit-Position: refs/heads/master@{#420589}

Powered by Google App Engine
This is Rietveld 408576698