Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2360673003: kernel->ssa: Implement for-loops and while-loops (Closed)

Created:
4 years, 3 months ago by Harry Terkelsen
Modified:
4 years, 3 months ago
Reviewers:
Johnni Winther, sra1
CC:
reviews_dartlang.org, dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

kernel->ssa: Implement for-loops and while-loops This involved splitting out the loop handling logic from the original SSA builder and sharing it with the kernel builder. This was just the easiest way to do this for now, but in the future we should write the loop handler for kernel to take into account the simplified structure that kernel provides. R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/3a01cbd31c5c4787dd6578a6f6fd767caef13fbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+804 lines, -539 lines) Patch
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 22 chunks +25 lines, -530 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 4 chunks +57 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 4 chunks +29 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/ssa/jump_handler.dart View 1 chunk +234 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 4 chunks +7 lines, -4 lines 0 comments Download
A pkg/compiler/lib/src/ssa/loop_handler.dart View 1 chunk +414 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/kernel/loops_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 3 months ago (2016-09-21 21:00:47 UTC) #2
sra1
LGTM. Perhaps as a separate cleanup, move loopDepth into the loop handler.
4 years, 3 months ago (2016-09-21 23:22:46 UTC) #3
Harry Terkelsen
4 years, 3 months ago (2016-09-21 23:38:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3a01cbd31c5c4787dd6578a6f6fd767caef13fbd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698