Add a transient image filter cache to SkImage::makeWithFilter & PDF

Add a transient image filter cache to SkImage::makeWithFilter & PDF

Added a bench for makeWithFilter (~23 ms -> ~6 ms median locally).

Also fixed indentation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360663002

Committed: https://skia.googlesource.com/skia/+/04a44d0fd45f5596c716e99e7a3bbcc03db0e05a

[Brian Osman, 2016-09-21 14:51:19]

Description was changed from

==========
Add a transient image filter cache to SkImage::makeWithFilter

Also fixed indentation.

BUG=skia:
==========

to

==========
Add a transient image filter cache to SkImage::makeWithFilter

Also fixed indentation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360663002
==========

[Brian Osman, 2016-09-21 14:51:39]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 14:51:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-09-21 14:51:59]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com, senorblanco@google.com

[Stephen White, 2016-09-21 15:01:11]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2016-09-21 15:01:11]

Could you try adding a bench for this? ImageFilterDAGBench is probably a good
model.

[robertphillips, 2016-09-21 15:05:26]

https://codereview.chromium.org/2360663002/diff/1/src/image/SkImage.cpp
File src/image/SkImage.cpp (right):

https://codereview.chromium.org/2360663002/diff/1/src/image/SkImage.cpp#newco...
src/image/SkImage.cpp:346: 
Is there no way we can just have one kDefaultImageFilterCacheSize ?

[Brian Osman, 2016-09-21 15:38:35]

Description was changed from

==========
Add a transient image filter cache to SkImage::makeWithFilter

Also fixed indentation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360663002
==========

to

==========
Add a transient image filter cache to SkImage::makeWithFilter & PDF

Added a bench for makeWithFilter (~23 ms -> ~6 ms median locally).

Also fixed indentation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360663002
==========

[Brian Osman, 2016-09-21 15:38:35]

brianosman@google.com changed reviewers:
+ halcanary@google.com

[Brian Osman, 2016-09-21 15:39:21]

Centralized cache size, added cache to PDF, added bench.

https://codereview.chromium.org/2360663002/diff/1/src/image/SkImage.cpp
File src/image/SkImage.cpp (right):

https://codereview.chromium.org/2360663002/diff/1/src/image/SkImage.cpp#newco...
src/image/SkImage.cpp:346: 
On 2016/09/21 15:05:26, robertphillips wrote:
> Is there no way we can just have one kDefaultImageFilterCacheSize ?

Done.

[Brian Osman, 2016-09-21 15:39:26]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 15:39:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Stephen White, 2016-09-21 15:47:04]

https://codereview.chromium.org/2360663002/diff/20001/src/core/SkImageFilterC...
File src/core/SkImageFilterCache.h (right):

https://codereview.chromium.org/2360663002/diff/20001/src/core/SkImageFilterC...
src/core/SkImageFilterCache.h:51: enum { kDefaultSize = 32 * 1024 * 1024 };
I support the idea of centralizing this, but calling it kDefaultSize
is a little misleading.

SkImageFilterCache::Get(), used by the raster path, returns a (persistent) 128MB
cache, and doesn't use this value (it's in the .cpp).

Maybe we should call this one kDefaultTransientSize or
kDefaultTransientCacheSize or something, to distinguish it from the persistent
cache size?

[robertphillips, 2016-09-21 15:50:25]

lgtm % Stephen's comment & Hal's feedback

https://codereview.chromium.org/2360663002/diff/20001/bench/ImageFilterDAGBen...
File bench/ImageFilterDAGBench.cpp (right):

https://codereview.chromium.org/2360663002/diff/20001/bench/ImageFilterDAGBen...
bench/ImageFilterDAGBench.cpp:73: sk_sp<SkImageFilter> mergeFilter =
SkMergeImageFilter::Make(inputs, kNumInputs);
The use of subset & offset here scares me a bit.

[hal.canary, 2016-09-21 15:51:39]

PDF: lgtm

[Brian Osman, 2016-09-21 16:02:01]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 16:02:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-09-21 16:03:27]

Renamed enum to kDefaultTransientSize. Fixed dangerous aliasing in the bench.
Move the PDF cache construction into an override of getImageFilterCache.

[Stephen White, 2016-09-21 16:06:22]

LGTM. Thanks for the fix!

[Brian Osman, 2016-09-21 16:07:16]

The CQ bit was unchecked by brianosman@google.com

[Brian Osman, 2016-09-21 16:07:20]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-09-21 16:07:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com, halcanary@google.com
Link to the patchset: https://codereview.chromium.org/2360663002/#ps40001
(title: "Fix PDF device more - override getImageFilterCache")

[commit-bot: I haz the power, 2016-09-21 16:07:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 16:46:59]

Description was changed from

==========
Add a transient image filter cache to SkImage::makeWithFilter & PDF

Added a bench for makeWithFilter (~23 ms -> ~6 ms median locally).

Also fixed indentation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360663002
==========

to

==========
Add a transient image filter cache to SkImage::makeWithFilter & PDF

Added a bench for makeWithFilter (~23 ms -> ~6 ms median locally).

Also fixed indentation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360663002

Committed:
https://skia.googlesource.com/skia/+/04a44d0fd45f5596c716e99e7a3bbcc03db0e05a
==========

[commit-bot: I haz the power, 2016-09-21 16:47:00]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/04a44d0fd45f5596c716e99e7a3bbcc03db0e05a