Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2360653002: [wasm] FromJS throws a TypeError for I64 values. (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] FromJS throws a TypeError for I64 values. This behavior is required by the WebAssembly spec. TEST=mjsunit/wasm/ffi-error.js:I64ParamsInSignatureThrows R=titzer@chromium.org Committed: https://crrev.com/4c1d574b22f75f4c59a124cd4fc4d21bae4a19e1 Cr-Commit-Position: refs/heads/master@{#39600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M test/mjsunit/wasm/ffi-error.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ahaas
4 years, 3 months ago (2016-09-21 14:32:37 UTC) #1
titzer
On 2016/09/21 14:32:37, ahaas wrote: lgtm
4 years, 3 months ago (2016-09-21 14:38:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360653002/1
4 years, 3 months ago (2016-09-21 14:48:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 15:32:27 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 15:33:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c1d574b22f75f4c59a124cd4fc4d21bae4a19e1
Cr-Commit-Position: refs/heads/master@{#39600}

Powered by Google App Engine
This is Rietveld 408576698