Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 236063018: Fill out the rest of the net targets in the GN build except Android. (Closed)

Created:
6 years, 8 months ago by brettw
Modified:
6 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Fill out the rest of the net targets in the GN build except Android. This also fixes some missing base files and libresolv naming. R=jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264296

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+488 lines, -132 lines) Patch
M base/BUILD.gn View 4 chunks +13 lines, -2 lines 0 comments Download
M build/config/linux/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M net/BUILD.gn View 1 2 6 chunks +474 lines, -129 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
6 years, 8 months ago (2014-04-15 20:36:52 UTC) #1
brettw
Ricardo is out, sending to jar
6 years, 8 months ago (2014-04-15 20:37:15 UTC) #2
jar (doing other things)
LGTM % nit https://codereview.chromium.org/236063018/diff/20001/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/236063018/diff/20001/net/BUILD.gn#newcode40 net/BUILD.gn:40: disable_ftp_support = is_ios nit: I *HATE* ...
6 years, 8 months ago (2014-04-15 21:16:17 UTC) #3
brettw
6 years, 8 months ago (2014-04-16 20:34:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r264296 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698